Handle empty arrays in pure Python API - #166
Open
karlhillx wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #164 by making the pure-Python sgp4_array() / SatrecArray.sgp4() implementations return correctly shaped/dtyped NumPy outputs for zero-length time inputs, matching the accelerated (C++) behavior. It also adds regression tests to lock in the expected behavior for empty arrays.
Changes:
- Preallocate
e,r, andvarrays in the pure-PythonSatrec.sgp4_array()and fill them in-place to support zero-length inputs. - Preallocate
e,r, andvarrays in the pure-PythonSatrecArray.sgp4()for consistent output shapes with empty inputs. - Add unit tests asserting shapes and dtypes for empty-array inputs for both APIs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
sgp4/model.py |
Updates pure-Python array APIs to preallocate outputs so empty inputs return correct shapes/dtypes. |
sgp4/tests.py |
Adds regression tests validating shapes/dtypes for empty-array inputs in both Satrec and SatrecArray array APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.
The pure-Python
sgp4_array()path now preallocates output arrays before looping, so zero-length inputs return the same shapes and dtypes as the accelerated implementation.Also adds regression coverage for
Satrec.sgp4_array()andSatrecArray.sgp4().Tested with:
python3 -m unittest sgp4.tests