Repository navigation
Add Polar H10 BLE ECG and HR/RR acquisition - #885
Open
Andrey1994 wants to merge 2 commits into
Open
Andrey1994 wants to merge 2 commits into
Andrey1994 wants to merge 2 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
POLAR_H10_BOARD(73) using SimpleBLE. The default preset contains 130 Hz ECG in microvolts, the PMD device clock and a preparation-time battery reading. The auxiliary preset preserves every HR/RR event, including multiple RR intervals in one notification; it explicitly declares an irregular sampling rate of 0 rather than representing the events as a uniform waveform.The driver selects an advertised H10 by optional address/device ID, subscribes to control indications or notifications according to the characteristic, checks the 130 Hz/14-bit ECG settings, validates multipart PMD responses, and waits for both a successful START acknowledgement and ECG data. Errors, missing replies and cleanup are covered through a transport seam using the actual driver lifecycle. All binding IDs and documentation are aligned.
Validation: warnings-as-errors Linux build; all 67 native tests pass, including Polar's published signed ECG fixture, settings and HR/RR parsing, control rejection, missing responses, first-data timeout, stop/restart and release/reprepare. These tests are part of the existing native CI suite. BLE discovery/subscription timing and physical H10 operation remain unverified; accelerometry, compressed frames, offline recording and other Polar models are outside this PR.
Reference: official Polar BLE SDK.