Repository navigation
Add BITalino six-channel serial acquisition - #882
Open
Andrey1994 wants to merge 2 commits into
Open
Andrey1994 wants to merge 2 commits into
Andrey1994 wants to merge 2 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
BITALINO_BOARD(70) for original BITalino / (r)evolution serial acquisition over USB or a pre-paired Bluetooth Classic RFCOMM port. This initial profile acquires all six analog inputs at 1000 Hz, returning uncalibrated ADC counts and four digital inputs. It validates the firmware handshake, spaces commands, supports firmware simulated mode, checks CRC4, and requires two consecutive frames to recover alignment.Updates every binding that declares board IDs (C/C++, Python, C#, Java, Julia, MATLAB, Node.js, Rust and Swift; R uses Python). Documentation explains sensor-specific calibration, host timestamps, configuration and unsupported BLE models/rates.
Validation: warnings-as-errors Linux build; all 65 native tests pass. A pseudo-terminal integration test verifies exact channel values, command sequencing, first-sample timeout recovery, repeated start/stop and release/reprepare; this runs in Linux CI. Physical BITalino and Bluetooth serial testing remain outstanding.
Protocol reference: BITalinoWorld/cpp-api. The new parser uses bit-field extraction and polynomial CRC computation, with independent golden packet tests.