Repository navigation
Conversation
The pin triggers ran for every app in tbl_iconinfo, the Media tab's too. They now fire only for games on the row (visible = 1, dispLocation 138), and lineupd replaces the older triggers when it starts, after a backup. Options -> Save a report for a bug writes /data/lineup/report.json with the columns that tell Games and Media apps apart, to look into the Media tab apps that stop opening (#4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
L1 and R1 switch between the Games and Media tabs. /row takes tab=games|media; the Media tab (dispLocation 188) has no pins and no home screen edge yet, and the app shows it without moving or pinning. Switching with unsaved changes on the Games tab asks to save or discard first (#3). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A busy database could hold the backup longer than the app waits for the service to answer at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
update_pin_triggers no longer takes a step error for the end of the scan. The report is still written when a query fails, but the answer says it is incomplete. Its text no longer says there is no account data: it has each profile's number.
lineupd's triggers now keep pins on the Games and Media tabs, reordering only the tab of the app that fired them. POST /row takes the tab, saving one tab keeps the other's pins, and one of the first 11 Media places stays unpinned. Triggers from 1.4.3 and older are replaced at start, after a backup.
Closes #3, and answers #4: Media apps can be pinned on the home row. Homebrew Media apps such as the jailbreak, Shadow Mount+ and a web file manager are deeplink apps that fail to open from the Media library (
m_is_pkg value is false, the CE-105773-3 in #4), so pinning them on the home row is the fix. Stacked on #6 (basev1.4.3).What changes
GET /rowandPOST /rowtaketab=games|media(defaultgames). Media readsvisible = 1 AND dispLocation = 188in home order.Verification
scripts/test.shpasses, including a new Media scenario: a fully pinned tab is refused, a Media pin holds through a write, saving one tab keeps the other's pins, and a Media save with no pins keeps the Games triggers. The round trip on a realapp.dbcopy also passes.scripts/build.shpasses.app.db. The host tests cover it against the real database.