Repository navigation
ci: run development build once per pull request - #320
Merged
Merged
Conversation
Restrict the push trigger to develop. Branches with an open pull request were built twice, once for push and once for pull_request.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #320 +/- ##
==========================================
Coverage 50.65% 50.65%
Complexity 80 80
==========================================
Files 40 40
Lines 458 458
Branches 9 9
==========================================
Hits 232 232
Misses 221 221
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every push to a branch with an open pull request started the
Development branchesworkflow twice — once forpush, once forpull_request— running the identical Maven build.Changes
pushtrigger todevelop. Pull requests are still built viapull_request, anddevelopis still built after each merge.github.event_name == 'push'condition from the Codecov upload step so coverage is still reported for pull requests (previously it came from the branch push run). Dependabot stays excluded because its runs cannot readCODECOV_TOKEN.Notes
Build and run testsis unchanged, so a required status check bound to thepull_requestrun keeps working.