Repository navigation
Advanced locale handling - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
delocalize(pattern, fromLocale) => patternFormat patterns in Excel can be localized. So something that reads
[red]#,##0.00in an en-US locale, will be exposed as[rot]#.##0,00in a de-DE locale. We now support converting format patterns from a locale to the default/canonicalen-USvariant. There a some differences in the locale data between MacOS and Windows but both should work fine.Closes #23.
Adds
getFormatFromId(fmtId, l10n) => patternExcel has a number of built in ID for number formats. These will change depending on locale (they are lconstructed based on locale format settings). We now support converting an Excel format ID to the corresponding format pattern in a supported locale. Again, the returned values for these vary between Excel on MacOS vs Windows. The Windows output has been emulated in all cases.