Repository navigation
Cut time coord for ymd chunking - #14
Open
GianmarcoLattaruolo wants to merge 4 commits into
Open
GianmarcoLattaruolo wants to merge 4 commits into
GianmarcoLattaruolo wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cartesian product of the
year,month,day, andtimelists can extend past the last date available in the dataset. This change adds anexpected_end_dateoption torequest_chunker_kwargs. For year/month/day requests, the reconstructed time coordinate is trimmed at that date, which is inclusive. Chunk sizes are resized so they still add up to the shorter coordinate. A chunk request that crosses the cutoff is kept unchanged, and requests that fall entirely after it are dropped.