Replace manual OAuth setup with browser-based PKCE login - #23
Open
tomas wants to merge 1 commit into
Open
Conversation
Adds OAuth 2.0 Authorization Code + PKCE (RFC 7636) login via a local callback server. Users now run `bootic login` to open a browser and authenticate — no client_id/secret copy-paste required. Only a public client_id is bundled (no secret). The local server tries ports 33100-33110 to avoid conflicts. Legacy `setup` command kept for custom OAuth apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bootic loginclient_idis bundled, no secret requiredbootic setupis preserved for users who need a custom OAuth app (non-production environments, self-hosted)How it works
bootic loginstarts a local callback server on the first free port in 33100–33110http://localhost:<port>/callback?code=...POST /oauth/tokenChanges
lib/bootic_cli/local_server.rb— new minimal TCPServer-based HTTP callback handlerlib/bootic_cli/session.rb— PKCE helpers,authorization_request,login_with_browser;setup?always truelib/bootic_cli/cli.rb—logincommand rewritten;setupsimplified to advanced-onlyspec/local_server_spec.rb— new unit tests for LocalServerspec/session_spec.rb— new unit tests for Session PKCE methods and URL constructionspec/bootic_cli_spec.rb— updated to match new login/setup flowTest plan
bundle exec rspec— 110 examples, 0 failuresbootic loginopens browser and completes authentication end-to-endbootic loginwhen already logged in prompts to re-authenticatebootic setupstill works for custom app credentials