Skip to content

Windows CI does not fail if one or more tests fail #521

Description

@stephengtuggy

While I was working on updating the Windows CI, I noticed that some tests were failing, but the test suite -- and the GitHub Actions workflow as a whole -- succeeded anyway. We should probably change that.

Activity

  1. stephengtuggy commented on Jun 27, 2026

    @stephengtuggy
    ContributorAuthor

    OK, maybe I was mistaken. All the errors and failures I'm seeing now are expected errors or XFAILs. So everything is passing after all, it seems.

  2. stefanseefeld commented on Jun 28, 2026

    @stefanseefeld
    Member

    faber prints a test summary with overall stats that should indicate how many real errors were observed in the run. (And it is supposed to fail the overall call if unexpected failures were encountered.)

  3. stephengtuggy commented on Jun 28, 2026

    @stephengtuggy
    ContributorAuthor

    @stefanseefeld Understood.

    I was working on a Pull Request anyway, and among other things, I was trying to fix the caching of vcpkg dependencies, but I'm not having much luck, so I'll probably just close it.

  4. stephengtuggy commented on Jun 28, 2026

    @stephengtuggy
    ContributorAuthor

    vcpkg caching seems to be working now! PR #522 is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions