Skip to content

transform_iterator does not work with std::sort from libc++ 22 #97

Description

@arybczak

If the comparator has a templated operator(), sorting through a boost::transform_iterator fails to compile with libc++ 22.

#include <algorithm>
#include <string>
#include <vector>
#include <boost/iterator/transform_iterator.hpp>

template <typename T> struct Wrapper { T item; };

struct Identity {
  Wrapper<std::string> &operator()(Wrapper<std::string> &w) const { return w; }
};

struct Cmp {
  template <typename T>
  bool operator()(const Wrapper<T> &a, const Wrapper<T> &b) const { return a.item < b.item; }
};

int main() {
  std::vector<Wrapper<std::string>> v{{"b"}, {"a"}};
  typedef boost::transform_iterator<Identity, std::vector<Wrapper<std::string>>::iterator> It;
  std::sort(It(v.begin()), It(v.end()), Cmp());
}
$ clang++ -std=c++17 -stdlib=libc++ -c repro.cpp
...
/usr/bin/../include/c++/v1/__algorithm/sift_down.h:55:7: error: no matching function for call to object of type
      'Cmp'
   55 |   if (__comp(__first[__child], __first[__start]))
      |       ^~~~~~
repro.cpp:14:8: note: candidate template ignored: could not match 'Wrapper' against 'operator_brackets_proxy'
   14 |   bool operator()(const Wrapper<T> &a, const Wrapper<T> &b) const { return a.item < b.item; }
      |        ^
...

See also llvm/llvm-project#223290.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions