Repository navigation
Conversation
When CI=true or stdout is not a TTY, spinner() and progress() now print append-only plain lines: no cursor hide/show, no spinner frames, and no progress bar redraws. TTY interactive behavior is unchanged. Fixes bombshell-dev#629
🦋 Changeset detectedLatest commit: 7e09787 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
hey @webywz please tell your agent to respect the PR's template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #629.
When
CI=true(or the output stream is not a TTY),spinner()andprogress()previously still calledblock()(cursor hide/show) and emitted spinner frames / progress-bar redraws with erase sequences. CI log viewers then showed noise like^[?25land^[1G^[J.This change adds a shared
isPlainLiveOutput(output)helper (CI=trueor!isTTY) and uses it in both components:message()lines → final◇/■/▲status line. Noblock(), frames, or cursor/erase codes.advance()without a new message is silent (avoids bar-only spam).plainMessageUpdates(defaulttrue) to skip mid-runmessage()lines in plain mode when desired.Test plan
vitestforspinner/progress/ accessible / new plain suites (123 tests)CI=trueand non-TTYisCI = truecases