[mixto]

What does this PR do?

Migration to the organisation’s tooling using @bomb.sh/tools. This pull request updates the repository in relation to this #506 other one, which is very out of date.

• I have used the tsconfig.json configuration from the tools repository. I have left the compiler options that were not defined in the tools configuration.

• The deps script uses knip to check dependencies. The bsh lint command in the tools already uses knip when run. As the script is also used in workflows, it should be left as it is. I use pnpm dlx to call the knip binary directly.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 13eac9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	vitest-ansi-serializer@​0.1.2 ⏵ 0.3.1	+5		+1	+7
	@​bomb.sh/​tools@​0.8.0
	vitest@​3.2.4 ⏵ 5.0.0	+1	+75	+1	+1
	@​types/​node@​20.19.39 ⏵ 20.19.43	+1		+1
	jsr@​0.13.4 ⏵ 0.13.5	+1
	knip@​5.62.0 ⏵ 6.44.1	+6		+2
	@​changesets/​cli@​2.31.0 ⏵ 2.31.1	+1		+1

View full report

[pkg-pr-new]

• @example/basic

• @example/changesets

  npm i https://pkg.pr.new/@clack/core@604
  

  npm i https://pkg.pr.new/@clack/prompts@604
  

commit: 13eac9c

[dreyfus92]

thanks for picking this up @mixto! i went a bit ham and down the rabbit hole with this one and there are a couple of loose ends we need to figure out, this will remain blocked until we figure out how to address all the stuff we need before making the shift.

the big one is that the test job is green but the suite is failing. the run on this pr reports 1698 failed | 796 passed and still exits 0, because bsh test never passes vitest's exit code thru. we need to fix this in tools, otherwise nothing catches a broken test once it lands.

once the exit code is honest there are real failures. 17 of the 19 prompt suites fail because the serialaizer bsh uses writes <cyan> style tags where our snopshots have raw escapes. bsh test -u fixes all of them and it's notation only.

the root bsh tes also runs everything 3 to 5 times, since the tools config excludes node_modules/** for some reason instead of **/node_modules/** and vitest walks into examples/*/node_modules/@clack/*. even with that excluded path.test.ts fails from rooth because vi.mock('node:fs') looks for __mocks__ relative to the vitest root. maybe we could keep pnpm -r run test like main had? with regenerated snapshots that passes both packages, though it still needs the tools fix to actually fail on failures.

cc. @43081j

[dreyfus92]

building prompts writes 38 untracked .d.ts and .d.ts.map files into packages/core/src, and since pretest builds, every pnpm test leaves them behind. the dts step picks up packages/prompts/tsconfig.json as its root, and the root paths alias pulls core's sources in from outside it, so their declarations land next to them. dropping packages/prompts/tsconfig.json so it falls back to the root one builds with no stray files. could we try that here?