Repository navigation
fix(ci): Grafana compat check ignores cancelled queries - #556
Merged
Merged
Conversation
The Dashboards job failed on main (run 41032511187) although all four Grafanas rendered 12/12 boards with 0 panel errors. Grafana 11.6.6 logged "Failed getting data source" err="context canceled": a query the browser dropped when it moved on to the next board. The log scan counted it as a failure. A data source that really fails still shows as a panel error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kafka charts / Dashboards job failed on main in run 41032511187, and the gate failed with it. All four Grafanas rendered 12/12 boards, 253 panels, with 0 panel errors. Grafana 11.6.6 still failed because it logged this line:
That is a query the headless browser dropped when it moved on to the next board. The Grafana log scan in
scripts/check-grafana-compat.shcounted it as a failure. This PR addscontext canceledto the scan's noise filter. A data source that really fails (for exampleconnection refused) still fails the scan, and it also shows as a panel error in the browser half.Tested locally:
./scripts/check-grafana-compat.sh 9.5.21 10.4.19 11.6.6 12.3.1passes on all four versions. The filter drops the cancelled-query line and keeps aconnection refusedline.