Skip to content

Allow websockets for extensions - #4020

Merged
patrickelectric merged 1 commit into
bluerobotics:masterfrom
joaoantoniocardoso:allow_websockets_for_extensions
Jul 24, 2026
Merged

Allow websockets for extensions#4020
patrickelectric merged 1 commit into
bluerobotics:masterfrom
joaoantoniocardoso:allow_websockets_for_extensions

Conversation

@joaoantoniocardoso

Copy link
Copy Markdown
Member

This is a less strict approach than #3947: extensions can normally use upgrade headers (from 1.1) and have WebSocket running with extensionsv2, without any ties to a specific path.

Resulting config:

image

@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Adds the three standard nginx WebSocket upgrade headers (proxy_http_version 1.1, Upgrade $http_upgrade, Connection "Upgrade") to the generated /extensionv2/{name}/ location block in core/services/helper/main.py:481, so extensions running behind the helper's reverse-proxy config can use WebSockets. The pattern matches the convention already established in core/tools/nginx/nginx.conf for /webrtc/ws/, /network-test/, /system-information/, /terminal/, /zenoh/, and /zenoh-api/.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@joaoantoniocardoso joaoantoniocardoso added the move-to-stable Needs to be cherry-picked and move to stable label Jul 24, 2026
@patrickelectric
patrickelectric merged commit 252fca2 into bluerobotics:master Jul 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

move-to-stable Needs to be cherry-picked and move to stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants