Skip to content

Point report.yml at the moved render module - #3

Open
dignajar wants to merge 1 commit into
mainfrom
fix/report-render-path
Open

dignajar wants to merge 1 commit into
mainfrom
fix/report-render-path

Conversation

@dignajar

Copy link
Copy Markdown
Member

report.yml still inserted scripts on sys.path after the machinery moved under .github, so its render step failed with:

ModuleNotFoundError: No module named 'render'

The gate was never affected — analyze.yml ran, decided pass or fail, and uploaded its report. What broke is the half that reports it: no comment was posted and no label was applied, so a pull request kept whatever label the previous run left. That is why #1 shows a green check and a stale needs-changes.

Caught by run 35495537365 on #1.

Verified by running the render step's exact snippet against the report artifact from that pull request: errors=0, warnings=1, comment renders.

Also corrects the regeneration command in .github/rules/reserved.json, stale from the same move.

Moving the scripts under .github left report.yml inserting 'scripts' on
sys.path, so the render step died with ModuleNotFoundError and no comment
or label was ever posted. The gate itself was unaffected, analyze.yml
still ran and still decided pass or fail, but every pull request kept
whatever label it had from the run before.

Verified by running the render step against the report from the jodit
pull request: errors=0, warnings=1, and the comment renders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant