Repository navigation
feat(ui): open files dropped onto the window - #51
Merged
Merged
Conversation
Accept drops of local files on MainWindow, accept the drag when at least one local file URL is present, and load the first one through LoadFile, so drops share the Open dialog path (recent files included). Adds a GUI test that sends drag-enter and drop events to the window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #24: dropping a local file onto the window opens it.
setAcceptDrops(true)onMainWindowdragEnterEventaccepts when the mime data contains a local file URLdropEventloads the first local file throughLoadFile, so drops behave exactly like File > Open (including recent files)MainWindowTest.OpensFileByDropsends drag-enter/drop events and checks the window titleVerification
ctest: 62/62 tests pass../test/tools/tidy.sh mainwindow.cpp mainwindow.h test/test_gui.cpp: 0 issues.Fixes #24