Skip to content

Enable incremental artifact reads on every relay - #8975

Merged
dr0uleau merged 3 commits into
mainfrom
drouleau/default-incremental-reads
Nov 3, 2026
Merged

dr0uleau merged 3 commits into
mainfrom
drouleau/default-incremental-reads

Conversation

@dr0uleau

@dr0uleau dr0uleau commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Why

Compatible clients need incremental artifact reads for local collections on every Buzz relay.

What

Expose incremental artifact reads and capability discovery on every Buzz relay.

How

Serve incremental queries through the existing authentication and authorization checks. Keep the existing work budgets and the separate WebSocket sync capability. The HTTP test verifies capability discovery and a successful incremental query.

Risk

The relay starts no additional background work. Clients that use incremental reads consume database capacity. The net database load is not yet measured. Serving writers must maintain the modification timestamps.

Testing

Read-only SQL checks on November 3, 2026 verify the prerequisites below. Each database records successful migrations 76–78. All five required columns have the expected types, defaults, and nullability. All five indexes have the expected definitions and are valid, ready, and live.

Deployment Schema and indexes Running timestamp writers
Production bb-block Pass f6f6d9a includes PR 8523
Production bb-public Pass f3a7bab includes PR 8523
Staging bb-block Pass b4509de includes PR 8523

The checked columns are artifact_heads.modified_at, artifact_revisions.modified_at, artifact_revisions.source_channel_id, channel_members.sync_modified_at, and communities.artifact_policy_modified_at. The checked indexes are idx_artifact_revisions_artifact, artifact_heads_modified, artifact_heads_channel, channel_members_sync, and artifact_revisions_moves.

At commit 62b26ad, all 21 NIP-11 tests and the HTTP capability test pass on Linux with PostgreSQL 17 and Redis. The HTTP test checks capability discovery and a successful incremental query. All required push hooks also pass.

No manual testing. Human confirmation remains pending.

Bigger picture

Client PR 1507 uses the advertised capability for local artifact sync. Existing deployments receive this behavior when they deploy the relay version that includes this PR.

Generated with Codex

Signed-off-by: Daniel Rouleau <drouleau@squareup.com>
@dr0uleau
dr0uleau marked this pull request as ready for review November 3, 2026 00:26
@dr0uleau
dr0uleau requested a review from a team as a code owner November 3, 2026 00:26
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: 0e5a69962e5cbe5e81ea46b557770ce27a120a14...62b26ad7386caaad299ee6c619c011c024b7af51
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

No concrete security, correctness, or reliability regressions found in the authorized PR range.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only source and history inspection. Builds, tests, and repository scripts were not executed.

Generated by Codex Security Review |
Requested by: @dr0uleau |
Workflow run

Signed-off-by: Daniel Rouleau <drouleau@squareup.com>
@dr0uleau dr0uleau changed the title Enable incremental artifact reads by default Enable incremental artifact reads on every relay Nov 3, 2026
@github-actions github-actions Bot added codex-security-review-current The posted Codex security review matches its recorded range. and removed codex-security-review-current The posted Codex security review matches its recorded range. labels Nov 3, 2026
@dr0uleau
dr0uleau requested a review from gilgtm November 3, 2026 17:05
Signed-off-by: Daniel Rouleau <drouleau@squareup.com>
@dr0uleau
dr0uleau requested a review from kazemek21 November 3, 2026 17:10
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 3, 2026
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 3, 2026
@dr0uleau
dr0uleau merged commit a9aa1f7 into main Nov 3, 2026
90 checks passed
@dr0uleau
dr0uleau deleted the drouleau/default-incremental-reads branch November 3, 2026 18:58

This branch was previously deployed

1 inactive deployment
codex-review — 62b26ad7 Deployed Nov 3, 2026 by dr0uleau via Run Codex Security Review #12173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants