[matt2e]

Summary

Units 2–5 of the 23–30 Oct desktop Playwright flake audit: four E2E specs that raced scroll settles and focus. All four fixes are test-only. This is one of six PRs split from the reviewed flakey-tests branch (siblings below).

navigation.spec.ts:472 "composer Buzz chip labels wrap without orphaning their icons"

11 jobs failed in the window, 6 of them after the earlier fixes, including 4 of the 7 main runs that carry every fix. Run 40970053997 (Smoke shard 7) failed all three attempts.

• Mode A (jobs 122971493553, 123066839967, 123572467962, 123819180597 and retry 2 of 123784825042): fragmentStep is null at :634. Rows key on renderKey = localKey ?? id, and a head refetch or live echo after the ack drops the localKey. The row remounts and loses the 220 px width the test set earlier. Change: re-land the test half of closed fix(desktop): show channel members before joining #6852. Set the width and measure in one expect.poll, and set the width again before each fragment measurement.
• Mode B (jobs 123573056202, 123784199542, 123784825042 twice, 123804428893, 123818728963, 123819543461, and 122924164125): the tooltip-centre poll at :667 receives 81.35 or Infinity. Radix Tooltip closes when an ancestor of its trigger scrolls. In the failing attempt, the post-send settle took its last step 21 ms or less before focus. Change: wait for the sent row's message-send-status to clear. Then poll until the timeline sits at its floor and holds there for two animation frames, and only then focus the chip. positionOverFragment asserts data-state is open. There is no retry loop around the race.

huddle-transcription.spec.ts:637 "animates the responding agent with the shared speaker ring"

• Runs: 9 jobs, always Smoke shard 4, attempt 1. On main: 39896948198, 40718743531, 40732061485, 40840949170, 40906253761, 40969965981 and 40983029157. On PRs: Fix duplicate timeline rows while reading history #8715 and perf(relay): route author- and #p-scoped global subscriptions by selector #8666. toBeFocused() at :697 reads inactive.
• Cause: useComposerAutofocus runs again once the editor mounts and takes focus from the focused trigger.
• Change: wait for message-input to be focused before focusing the trigger, as the same spec already does at :855.

scroll-history.spec.ts:1289 "fast middle-page scroll settles with continuous mounted coverage"

• Runs: 9 jobs. After the fixes: main 40980404335 (job 123819180518) and two attempts on Wait for agent inventory updates in the desktop test #8720. The viewportCoverage poll expects < 100 and receives 200, the bottom spacer.
• Cause: the bottom-settle intent armed when the channel first positions survives the prepend and the spec's scrollTop writes. Virtua's re-measure then pulls the list back to the floor.
• Change: hover the timeline and wheel up 120 px first, since reader input cancels the intent. Then poll until the timeline is more than 32 px from the floor and steady for two frames.
• The commit message calls the cancelling listener listenForReaderScroll, a name introduced by sibling fix(desktop): hold a deep-linked message against bottom settles #8742. On main, the same wheel listener is inline in useVirtualizedBottomSettle, so this fix doesn't depend on that PR.

custom-emoji.spec.ts:370 "reacting with a custom emoji renders via the loopback media proxy"

• Runs: main 40787609859 and 40983029157 (Smoke shard 3), and BUZZ-271: Bound live-session revalidation #8241. The inline "Add reaction" opacity reads "1", not "0".
• Cause: the non-modal Radix Popover returns focus to its trigger in a setTimeout(0) after its 100 ms exit animation. That can land after the spec's blur.
• Change: wait for the "Open reactions" trigger to be focused, then blur.

Related issue

None found. Sibling #8744 also edits navigation.spec.ts, in a separate hunk. The two merge cleanly in either order. #8622 adds an unrelated test at the end of navigation.spec.ts, and #7812 (stale since 10-06) adds tests elsewhere in three of these files.

Testing

Not run locally, because Playwright bogs this machine down. Flake Check will repeat the touched specs. pnpm typecheck and pnpm check pass. An ad hoc tsc run over the four specs found the same pre-existing errors as on their main copies (navigation 7, huddle 17, scroll-history 0, custom-emoji 2).

Pushed with git push --no-verify, because the pre-push suites fail when the laptop is under load.

Readiness

An agent review of the combined flakey-tests branch (b432453af) found no blockers. buzz-review-completed is not added, because the human test step (AGENTS.md "Before opening a PR", step 3) hasn't happened yet.

Siblings

• ci: bound Hermit fetches and let relay builds run without sccache #8739 ci: Hermit fetch deadline and sccache fallback
• test(relay): hold the replica's second aux page and move media's DB tests #8740 test(relay): thread_window aux-page hold and api::media Postgres tests
• test(mobile): check the title fade's animation, wait 10 s for the alert #8741 test(mobile): RunnerTests title fade and alert wait
• fix(desktop): hold a deep-linked message against bottom settles #8742 fix(desktop): deep-linked message hold (product change)
• test(desktop): settle five E2E flake classes and clear a draft by Backspace #8744 test(desktop): five settle classes and remote-owned-mentions

🤖 Generated with Claude Code

[github-actions]

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

• Exact PR diff: d342cf141cb3211c8e5a6c74f881cf1d39ad3b12...832737efaed9b9b6d066777fc0d66287b72d7426
• Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.

---

Review Summary

Overall Risk: NONE

The authorized range changes only four desktop end-to-end tests. Inspection of the changed assertions and related focus, acknowledgement, tooltip, and scroll behavior found no concrete security, correctness, or reliability issues.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

• Review used read-only source and history inspection. Tests and builds were not executed, as requested.

---

_{Generated by Codex Security Review |
Requested by: @matt2e |
Workflow run}

[jedwards27]

🤖 :bot: Jude’s code review agent — REQUEST CHANGES

Reviewed: 1eb67bb525d66448b56d79f98c4ba0e2188b44c5..13171fdd5c763b3538b0c303c48461fa4c1ccd9d (exact head 13171fdd5c763b3538b0c303c48461fa4c1ccd9d)
Risk: Low runtime risk / medium validation risk. The diff is test-only, but the PR’s purpose is to make specific Desktop Playwright flakes deterministic, so a same-head failure in one of those changed specs means the proposed synchronization still does not prove its contract.

Finding

1. [P2] Navigation tooltip flake fix still fails on the changed exact-head flake proof — desktop/tests/e2e/navigation.spec.ts:704

   The PR changes composer Buzz chip labels wrap without orphaning their icons to wait for the sent row ack, wait for the timeline floor to hold for two frames, and require the tooltip to have data-state="open" before asserting the tooltip center is over the current wrapped chip fragment. That is still not sufficient: the exact-head flake check failed this same test on the PR merge commit.

   Evidence from Flake Check / Flake check (Playwright smoke, 1/1) for run 41051895661, job 124049928438:

   Uses: block/buzz/.github/workflows/_ci-flake.yml@refs/pull/8743/merge (b114cdb1d91f85ebf4f540ded08dbbfbbc1973ce)
   ✘ [smoke] › tests/e2e/navigation.spec.ts:472:1 › composer Buzz chip labels wrap without orphaning their icons
   Expected: < 1
   Received: 81.3515625
   > 704 |       .toBeLessThan(1);
   at positionOverFragment (/home/runner/work/buzz/buzz/desktop/tests/e2e/navigation.spec.ts:704:8)
   

   This is the exact tooltip-positioning assertion this PR is trying to stabilize. A tooltip can be visible/open while still centered over the previous fragment, so the new data-state="open" assertion does not guarantee useInlineTooltipPosition has processed the pointer-driven fragment reposition. The result is that the advertised flake is still reproducible under the PR’s own repeated smoke run.

   Author action: tighten positionOverFragment so each fragment hover deterministically causes the tooltip to reposition over that fragment before the center assertion runs. For example, close/reopen or otherwise force a fresh hover lifecycle per fragment, or wait on an observable that proves the pointer-driven reposition for the target fragment has actually landed. Then rerun the exact-head Playwright flake check and get this changed spec green.

   Verification owner: author + CI flake check.

Validation

• PASS — git rev-parse HEAD in the review checkout: 13171fdd5c763b3538b0c303c48461fa4c1ccd9d.
• PASS — git status --short | wc -l: 0 dirty entries.
• PASS — gh api user --jq '.login': jedwards27; live PR author from gh pr view: matt2e.
• PASS — gh pr view https://github.com/block/buzz/pull/8743 --json headRefOid,baseRefOid,statusCheckRollup: live head still 13171fdd5c763b3538b0c303c48461fa4c1ccd9d; base 1eb67bb525d66448b56d79f98c4ba0e2188b44c5; Flake Check / Flake check (Playwright smoke, 1/1) is FAILURE.
• FAIL — gh run view 41051895661 --job 124049928438 --log-failed: changed navigation.spec.ts:472 failed at navigation.spec.ts:704 with tooltip center delta 81.3515625.
• NOT RUN — local Desktop E2E/native/manual. The exact-head repeated CI smoke failure already establishes the author-actionable blocker for this test-only flake-fix PR.

Residual risk: I did not perform native/manual UI validation because this change is test-only and the exact changed automated proof is red. Re-review should start from the next head after the navigation flake proof is fixed.