Repository navigation
test(relay): fix main's build after the test-state helper rename - #8718
Merged
Merged
Conversation
#8676 renamed `test_state_with_database_url` to `test_state_with_unreachable_database_url` and pointed real-database tests at `test_state_with_database_url_and_pool_options`, while #8670 added a Postgres test that still called the old name. Each passed CI alone; together main's test targets no longer compile. Use the real-database helper with sqlx's default pool options, as the other Postgres-backed tests do. Co-authored-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Luke Tornquist <tornquist@squareup.com>
TheSentinel454
marked this pull request as ready for review
October 29, 2026 23:51
TheSentinel454
temporarily deployed
to
codex-review
October 29, 2026 23:51 — with
GitHub Actions
Inactive
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
TheSentinel454
enabled auto-merge (squash)
October 30, 2026 00:29
matt2e
approved these changes
Oct 30, 2026
Contributor
|
Thanks! |
shu-hui-cash
added a commit
that referenced
this pull request
Oct 30, 2026
…nity-storage-calculation * origin/main: fix(mobile): resolve iOS pushes on a fresh connection and retry a stale one (#8722) ci(loadgen): publish buzz-loadgen as ghcr.io/block/buzz-loadgen (#8717) test(relay): fix main's build after the test-state helper rename (#8718) fix(db): keep lease releases durable and deflake PostgreSQL lane tests (#8676) test: dedupe collect_until_eose by event id and uncap two shell tests (#8677) ci: cache the Tauri apt .debs and fit a cold Windows Rust run in its cap (#8679) test(desktop): gate flaky E2E specs on the state they assume (#8681) test(desktop): settle composer edits and press hover-only row actions by keyboard (#8682) Signed-off-by: Shu Hui <shu@squareup.com>
ravarora2
added a commit
that referenced
this pull request
Oct 30, 2026
…vent-guards * origin/main: (29 commits) Restyle community invitations (#8728) feat(relay): add incremental artifact reads (#8523) fix(mobile): show agent DM typing and balance reply bubble padding (#8731) perf(relay): route author- and #p-scoped global subscriptions by selector (#8666) fix(desktop): fix the product races behind four E2E flakes (#8680) test(scripts): stop file-size fixtures leaking git repos and fsmonitor daemons (#8727) test(mobile): keep late callbacks and fixed sleeps from failing tests (#8678) fix(mobile): resolve iOS pushes on a fresh connection and retry a stale one (#8722) ci(loadgen): publish buzz-loadgen as ghcr.io/block/buzz-loadgen (#8717) test(relay): fix main's build after the test-state helper rename (#8718) fix(db): keep lease releases durable and deflake PostgreSQL lane tests (#8676) test: dedupe collect_until_eose by event id and uncap two shell tests (#8677) ci: cache the Tauri apt .debs and fit a cold Windows Rust run in its cap (#8679) test(desktop): gate flaky E2E specs on the state they assume (#8681) test(desktop): settle composer edits and press hover-only row actions by keyboard (#8682) test(desktop): measure inline video controls against their player (#8683) relay: open the search pool lazily so a dead reader can't block boot (#8662) fix(mobile): address #8650 second-pass review (#8691) Revert "fix(mobile): push every message in your own Solo chats (#8615)" (#8690) fix: don't notify workflow owners through their attribution tag (#8694) ... Signed-off-by: Ravneet Arora <rarora@squareup.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main's
buzz-relaytest targets don't compile atef4130da:#8676 renamed
test_state_with_database_urltotest_state_with_unreachable_database_urland moved real-database tests totest_state_with_database_url_and_pool_options. #8670 had addeda_lost_open_set_invalidation_grants_a_revoked_channel_only_until_max_age, a Postgres test that still calls the old name. Each passed CI on its own; #8676 merged an hour after #8670 without re-running against it.This builds that test's two states with
test_state_with_database_url_and_pool_options(&database_url, PgPoolOptions::new()), the same helper and sqlx-default pool options the other Postgres-backed tests in this crate use. Test-only; no production code changes.What got simpler
Nothing; it restores the build.
Testing
cargo clippy --workspace --all-targets -- -D warningsandcargo fmt --checkon top ofef4130da.scripts/postgres-test-run.sh -p buzz-relay --lib -E 'test(/postgres_tests::/)'against a local Postgres, including the repaired test.🤖 Generated with Claude Code