Skip to content

test(relay): fix main's build after the test-state helper rename - #8718

Merged
TheSentinel454 merged 1 commit into
mainfrom
elrond/fix-main-open-set-test
Oct 30, 2026
Merged

TheSentinel454 merged 1 commit into
mainfrom
elrond/fix-main-open-set-test

Conversation

@TheSentinel454

Copy link
Copy Markdown
Contributor

Summary

main's buzz-relay test targets don't compile at ef4130da:

error[E0425]: cannot find function `test_state_with_database_url` in this scope
    --> crates/buzz-relay/src/state.rs:3375:30

#8676 renamed test_state_with_database_url to test_state_with_unreachable_database_url and moved real-database tests to test_state_with_database_url_and_pool_options. #8670 had added a_lost_open_set_invalidation_grants_a_revoked_channel_only_until_max_age, a Postgres test that still calls the old name. Each passed CI on its own; #8676 merged an hour after #8670 without re-running against it.

This builds that test's two states with test_state_with_database_url_and_pool_options(&database_url, PgPoolOptions::new()), the same helper and sqlx-default pool options the other Postgres-backed tests in this crate use. Test-only; no production code changes.

What got simpler

Nothing; it restores the build.

Testing

  • cargo clippy --workspace --all-targets -- -D warnings and cargo fmt --check on top of ef4130da.
  • scripts/postgres-test-run.sh -p buzz-relay --lib -E 'test(/postgres_tests::/)' against a local Postgres, including the repaired test.

🤖 Generated with Claude Code

#8676 renamed `test_state_with_database_url` to
`test_state_with_unreachable_database_url` and pointed real-database
tests at `test_state_with_database_url_and_pool_options`, while #8670
added a Postgres test that still called the old name. Each passed CI
alone; together main's test targets no longer compile.

Use the real-database helper with sqlx's default pool options, as the
other Postgres-backed tests do.

Co-authored-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Luke Tornquist <tornquist@squareup.com>
@TheSentinel454
TheSentinel454 marked this pull request as ready for review October 29, 2026 23:51
@TheSentinel454
TheSentinel454 requested a review from a team as a code owner October 29, 2026 23:51
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Oct 29, 2026
@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: ef4130da4bfeea9fe37477d621166675e0ab3ef7...d27db0b5f67ccfe4090dbcd1808fcfbd9f0474fd
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

The PR updates two test-state constructors to use the existing database helper with default pool options. Production behavior is unchanged. No concrete security, correctness, or reliability issues were found in the authorized diff.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review was limited to read-only source and history inspection; builds and tests were not executed.

Generated by Codex Security Review |
Requested by: @TheSentinel454 |
Workflow run

@TheSentinel454
TheSentinel454 enabled auto-merge (squash) October 30, 2026 00:29
@matt2e

matt2e commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@TheSentinel454
TheSentinel454 merged commit 0e8fb49 into main Oct 30, 2026
97 checks passed
@TheSentinel454
TheSentinel454 deleted the elrond/fix-main-open-set-test branch October 30, 2026 00:31
shu-hui-cash added a commit that referenced this pull request Oct 30, 2026
…nity-storage-calculation

* origin/main:
  fix(mobile): resolve iOS pushes on a fresh connection and retry a stale one (#8722)
  ci(loadgen): publish buzz-loadgen as ghcr.io/block/buzz-loadgen (#8717)
  test(relay): fix main's build after the test-state helper rename (#8718)
  fix(db): keep lease releases durable and deflake PostgreSQL lane tests (#8676)
  test: dedupe collect_until_eose by event id and uncap two shell tests (#8677)
  ci: cache the Tauri apt .debs and fit a cold Windows Rust run in its cap (#8679)
  test(desktop): gate flaky E2E specs on the state they assume (#8681)
  test(desktop): settle composer edits and press hover-only row actions by keyboard (#8682)

Signed-off-by: Shu Hui <shu@squareup.com>
ravarora2 added a commit that referenced this pull request Oct 30, 2026
…vent-guards

* origin/main: (29 commits)
  Restyle community invitations (#8728)
  feat(relay): add incremental artifact reads (#8523)
  fix(mobile): show agent DM typing and balance reply bubble padding (#8731)
  perf(relay): route author- and #p-scoped global subscriptions by selector (#8666)
  fix(desktop): fix the product races behind four E2E flakes (#8680)
  test(scripts): stop file-size fixtures leaking git repos and fsmonitor daemons (#8727)
  test(mobile): keep late callbacks and fixed sleeps from failing tests (#8678)
  fix(mobile): resolve iOS pushes on a fresh connection and retry a stale one (#8722)
  ci(loadgen): publish buzz-loadgen as ghcr.io/block/buzz-loadgen (#8717)
  test(relay): fix main's build after the test-state helper rename (#8718)
  fix(db): keep lease releases durable and deflake PostgreSQL lane tests (#8676)
  test: dedupe collect_until_eose by event id and uncap two shell tests (#8677)
  ci: cache the Tauri apt .debs and fit a cold Windows Rust run in its cap (#8679)
  test(desktop): gate flaky E2E specs on the state they assume (#8681)
  test(desktop): settle composer edits and press hover-only row actions by keyboard (#8682)
  test(desktop): measure inline video controls against their player (#8683)
  relay: open the search pool lazily so a dead reader can't block boot (#8662)
  fix(mobile): address #8650 second-pass review (#8691)
  Revert "fix(mobile): push every message in your own Solo chats (#8615)" (#8690)
  fix: don't notify workflow owners through their attribution tag (#8694)
  ...

Signed-off-by: Ravneet Arora <rarora@squareup.com>

This branch was previously deployed

1 inactive deployment
codex-review — d27db0b5 Deployed Oct 29, 2026 by TheSentinel454 via Run Codex Security Review #10776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants