Repository navigation
fix(deps): bump rustls to 0.23.46 for RUSTSEC-2026-0346 and -0347 - #8319
Merged
Merged
Conversation
cargo-deny now fails every branch on two new rustls 0.23.45 advisories: Debug output of client session values exposes TLS secrets (RUSTSEC-2026-0346), and buffered data can reach the outer server after an ECH rejection (RUSTSEC-2026-0347). 0.23.46 fixes both. Only the rustls entry changes in the root and desktop lockfiles. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
loganj
marked this pull request as ready for review
October 14, 2026 15:07
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
loganj
enabled auto-merge (squash)
October 14, 2026 15:11
brow
approved these changes
Oct 14, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
The required Security check now fails on every branch, including main. The dependency audit (
cargo-deny) reports two new advisories for rustls 0.23.45, the TLS library behind the relay, CLI and desktop connections:Debug(for example, in a log line) shows its TLS secret.rustls 0.23.46 fixes both. This PR moves the root and desktop lockfiles to it, so the Security check passes again.
Related issue
None found. #8277 fixed an earlier advisory in the same way.
Testing
cargo-deny checkpasses: "advisories ok, bans ok, licenses ok, sources ok".cargo tree --lockedresolves both lockfiles without more changes. Only the rustls version and checksum change. A plaincargo update -p rustlsalso moved unrelatedsynandgetrandomedges, so this PR leaves those out.