Repository navigation
Conversation
Extract only the accepted native-preparation boundary repair onto f7021f2. Keep native preparation in the command adapter and test persistence policy without dereferencing a synthetic MockRuntime AppKit handle. Co-authored-by: Dr. Spuxx, the Living Mutagen <dbeea7b641217ab95b3c75e547b999cc044d294afebbf240df7fe90c249de836@feedback.communities.buzz.xyz> Signed-off-by: Zach Marley <zmarley@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a standalone one-file repair, not the onboarding feature from #2336. No frontend, terminal, dependency, configuration or CI changes. Production net change is +10 lines; complete diff is +132/−8 including tests.
Validation
At reviewed head
8893c7004e7f889706980b6bf1c2ce479435f0b3:bin/cargo fmt --all --checkpassed.bin/cargo build --workspace --lockedpassed on macOS.cargo clippy --workspace --locked --all-targets -- -D warningspassed through the normal local pre-push job.bin/cargo test -p Buzz --lib --locked window_state::tests::onboarding_passed: 4 passed, 0 failed, 0 ignored (1,004 other tests filtered out). This is not the full workspace suite or personal human testing.Existing automatic PR CI is requested for full unfiltered workspace tests/doctests and the repository's other checks. PR CI normally checks GitHub's synthetic merge commit incorporating this head; pending results must be attributed to the actual tested revision, not represented as bare-head execution.
Remaining acceptance / draft status
8893c7004e7f889706980b6bf1c2ce479435f0b3: 4 passed, 0 failed, 0 ignored. The human affected-command testing item is satisfied; no scoped exception is needed. AppKit/Wry and full macOS workspace testing remain unperformed, not additional blanket gates for this unchanged-semantics repair. Keep draft until supported full CI is green and independently verified.Affected-workflow acceptance
Human confirmation concerns the focused regression workflow only, not GUI/AppKit, native onboarding acceptance or the full workspace suite.