Repository navigation
fix(members): preserve relay-recorded agent classification - #2363
Open
jpeedikayil wants to merge 1 commit into
Open
jpeedikayil wants to merge 1 commit into
jpeedikayil wants to merge 1 commit into
Conversation
Read optional agent markers from the verified roster independently of permission roles. Keep unknown identities in neutral member groups and preserve existing action restrictions and owner-read limits. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Josiah Peedikayil <174502694+jpeedikayil@users.noreply.github.com>
joahg
approved these changes
Nov 5, 2026
joahg
left a comment
joahg
left a comment
Member
There was a problem hiding this comment.
🤖 Read the roster-tag parsing and the Members dialog grouping; the agent tag is optional, pubkey-validated and must match a rostered role, so older rosters degrade to current behavior. The PR body says the relay-side agent tag contract still needs maintainer agreement, so don't merge ahead of that. Merge state is DIRTY, needs a rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Members can lose an enrolled agent's classification when public profile hints disappear. Channel roles also cannot identify an agent who is an admin or owner.
What
Use optional relay-signed agent evidence in Members. Keep known agents in Agents and use neutral Members/Others wording when evidence is missing.
How
Read agent tags from the existing verified roster. Preserve the current owner-read budget, permissions, messaging restrictions, shared rows and avatars. Channel roles alone do not establish agent identity.
Risk
Complete classification requires a supporting relay and a published roster. Older snapshots remain usable; missing evidence does not certify a human identity. The marker supplies no owner attribution or management rights.
Testing
No manual testing. Human acceptance and native validation remain pending. No browser cases were added or removed; existing journeys update group labels, while classification cases stay in the component and protocol tests.
Bigger picture
Client follow-up to block/buzz#8494, which derives ordinary
botroles from recorded ownership. This draft consumes a proposed separateagentroster tag, including for agents with Admin, Owner or Guest roles. The relay companion adds the marker and enrollment refresh. The field is optional, but classification from it requires a supporting relay and a republished roster. The proposed contract needs maintainer agreement before merge.Generated with Codex