[loganj]

Summary

When the relay refuses a write, buzz-app showed Relay rejected the message (400) or, on the web broker path, Relay request failed (503). The relay's own reason never reached the user. For example, the relay refuses to create an open channel with a taken name (block/buzz#8782) with invalid: an open channel named "Launch" already exists. The create dialog showed only a status summary.

Now the create dialog shows An open channel named "Launch" already exists, on the signed path (packaged and native builds) and on the development broker path (just desktop / just web with BUZZ_DEV_VIEWER). On the signed path this holds for every relay-shaped refusal. On the broker path it holds for validation (invalid:) refusals only; restricted: and blocked: still show a status summary there, as before this PR.

Details

• acceptPublish (src/features/relay/transport.ts)
  • For 400, 401, 403, 404, 413 and 422, it builds the display message from {error} text, but only when the text is relay-shaped, that is, it starts with a NIP-01 prefix (invalid, blocked, restricted, error, pow, duplicate). It removes the prefix and capitalizes the first letter.
  • Text without a prefix (for example, a gateway or VPN edge answering 403 {"error": "Forbidden by proxy"}) still shows Relay rejected the message (<status>). The prefix is a shape check, not proof of origin.
  • PublishRejected.reason keeps the raw text, so writers that classify by prefix (agent-config-artifacts.ts) work as before.
  • Text with a prefix that writers match on (conflict:, rate-limited:, auth-required:) is shown exactly as sent.
  • The 409 branch and the rate-limit handling are unchanged. A 200 receipt with accepted:false is unchanged; the name refusal comes as an HTTP 400, not on that path.
• Signed transport (src/features/relay/http-admission.ts)
  • Admission reduced every upstream 4xx body to Relay request failed (400) before acceptPublish saw it.
  • The signed publish now uses the existing caller-allowed reason hook to keep relay-shaped {error} text for the refusal statuses above. readApiFailure still bounds it. The hook's callback now also receives the HTTP status; existing callers are unaffected.
• Development broker (browser-host/relay-broker.mjs, src/features/relay/socket-requests.ts)
  • The broker publishes over WebSocket and answered every proven refusal with 503 Socket publication could not be confirmed.
  • A proven invalid: refusal now answers 400 with the relay's text (bounded at 16 KB by the socket receipt check), as the relay's HTTP API does. So both paths reach the same acceptPublish branch.
  • The broker log still gets only the safe summary (publicationRefusal), never the relay's text.
  • restricted:, blocked:, rate-limited:, conflict:, the read-state timestamp refusal and unconfirmed outcomes keep their current answers.

Testing

• transport.test.ts:
  • Each prefix is removed. Text that writers match on is kept as sent.
  • Text without a prefix, and missing or invalid bodies, fall back to the status summary on both the signed and broker transports.
  • The 409 branch is unchanged, and a 500 stays a status summary.
• relay-broker-live.test.mjs (the real broker, with a scripted relay socket):
  • A taken-name negative OK reaches the writer as PublishRejected with An open channel named "Launch" already exists.
  • The diagnostics test now expects 400 with the relay's text for invalid: refusals, and still checks that the log line holds only the safe summary and no private text.
  • With the broker change removed, these 3 cases fail.
• native.test.ts: one fixture now uses relay-shaped text.
• tsc --noEmit and biome check pass. vitest run browser-host src/features/relay src/features/developer src/features/agents src/features/channel-members src/bundled/channels src/bundled/workflows passes (5,432 tests) after the rebase onto main.
• Not done: a run against a live relay. buzz-app accepts only wss:// and https:// relay origins, and both dev paths use the developer's own account credential.

🤖 Generated with Claude Code

[kazemek21]

Kyle reviewed this PR and the Nexus review-tracker notes and approved with no comments.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

[wesbillman]

🤖 Star Lord’s automated source review via Wes’s account.

No actionable findings in the reviewed change. The signed path preserves bounded, relay-shaped refusal text through admission; the broker exposes proven invalid refusals to the requesting client while retaining sanitized diagnostic summaries. Raw reasons remain available to classifying writers. Conflict, quota and uncertain-delivery handling remain distinct.

Reviewed head: 2caec1d
Base: 6f341ce

Independent Rocket, Mantis and Groot lanes completed, with Star Lord integration. Source-only review of the seven-file diff, supporting transport/outbox/create-channel callers, tests and public PR material. No tests, builds, apps or live-relay workflows were run, and CI was not assessed. Actual error/retry focus, native/browser rendering and human acceptance remain unverified. This COMMENT is not approval or merge authorization.