Skip to content

refactor(profiles): read the directory's verified agent owner - #1595

Merged
baxen merged 1 commit into
mainfrom
larry/profile-owner-directory
Oct 25, 2026
Merged

baxen merged 1 commit into
mainfrom
larry/profile-owner-directory

Conversation

@loganj

@loganj loganj commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

🤖

Summary

  • No visible change. Agent messages still show "· Alex’s agent" when the owner is someone else, and only the robot mark when the agent is yours.
  • The label now reads the owner check that the app's profile store already does, instead of running a second check of its own. This removes a duplicate cache and its completion bookkeeping. Follow-up to feat(messages): show whose agent wrote a message #1502, from its review.

Details

  • One owner check. The profile store keeps each agent's latest signed profile. It checks the owner's signature (a NIP-OA auth tag) once per profile version and tells subscribers when the result is ready. Thread views already use that result. The message row now does too.
  • Same evidence as before. The store checks only profiles it read from the relay with a valid event signature. A missing or forged owner statement still shows no label. Ownership remains display information only.
  • Unchanged: the owner's own profile still loads in the background, and the row shows no label until the owner's name is known.
  • Test. The message-row owner test now uses the real profile store, so it covers the late result notification. If the row stops listening for that notification, the "signed owner" and "your agent" cases fail.

🤖 Generated with Claude Code

useProfileOwner kept its own verification cache. The profile directory
already verifies each retained head once and notifies subscribers when
the verdict lands, so the row now reads that result. The background
load of the owner's name is unchanged.

Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Logan Johnson <loganj@squareup.com>
@loganj
loganj marked this pull request as ready for review October 23, 2026 20:51
@loganj
loganj requested a review from a team as a code owner October 23, 2026 20:51

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 No actionable findings. Star Lord’s automated source review via Wes’s account, integrating independent Rocket, Mantis and Groot reviews, found the shared directory preserves head-bound owner verification, late notifications and background owner-name loading while removing the duplicate cache. Reviewed head 64291f4ae433d2190cd803214c83453fd713e520 against base 06d1347dab7bc825312d5f217cc2fd12cfab1de0. Source-only: no tests or app execution; the hosted CI snapshot was successful for executed checks, with Windows and browser flake checks skipped, so live rendering and performance remain unverified.

@baxen
baxen merged commit 98b9a80 into main Oct 25, 2026
37 checks passed
@baxen
baxen deleted the larry/profile-owner-directory branch October 25, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants