fix(components): gate the archived row's PR badge on the githubIntegration capability - #8
Draft
pythonlearner1025 wants to merge 1 commit into
Draft
Conversation
…ation capability
An archived session carries `pullRequests` whatever platform is reading it, so
the archive row draws a PR status glyph linking to github.com on a composition
that declares no `githubIntegration` and has no GitHub App behind the link.
`useAppCapability('githubIntegration')` is the check the Session surfaces make;
the archive row simply never asked.
`getArchivedSessionItemViewModel` gains a third parameter defaulting to true, and
drops the pull-request list with the capability off — which zeroes `prUrl`,
`prStatusMeta`, `PrIcon` and `prTooltipLabel` together, the same shape
`getSessionGitHubState` uses. Both item components read the capability and pass
it.
No new prop and no new capability.
Model: claude-opus-5[1m]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An archived session carries
pullRequestswhatever platform is reading it, sothe archive row draws a PR status glyph linking to github.com on a composition
that declares no
githubIntegrationand has no GitHub App behind the link.useAppCapability('githubIntegration')is the check the Session surfaces make;the archive row simply never asked.
getArchivedSessionItemViewModelgains a third parameter defaulting to true, anddrops the pull-request list with the capability off — which zeroes
prUrl,prStatusMeta,PrIconandprTooltipLabeltogether, the same shapegetSessionGitHubStateuses. Both item components read the capability and passit.
No new prop and no new capability.
Compatibility
Every change is additive at its default. With the new prop, parameter or flag
absent, the touched components render and behave exactly as they do today, and
no existing call site in this repository passes one.
Testing
packages/componentstypecheck and the full vitest suite pass. No new test:getArchivedSessionItemViewModelis module-private, so the assertion would have to go through a rendered row. Exporting it for a test is a change this PR did not want to make on its own; say the word and it can.Notes for the reviewer
Same shape as the
getSessionGitHubStategate in the Session surfaces, applied to the one row family that never asked.Review metadata
BlitzOS fork only. Delete this section before sending the PR to
LodyAI/Lody.blitz/seam-14-archive-pr-badge-capability-gatef3474894 (the pinned upstream commit)