fix(components): mount the quick-open file dialog on desktop - #3
Draft
pythonlearner1025 wants to merge 1 commit into
Draft
fix(components): mount the quick-open file dialog on desktop#3pythonlearner1025 wants to merge 1 commit into
pythonlearner1025 wants to merge 1 commit into
Conversation
`{fileQuickOpenDialog}` is mounted only inside the `if (isMobile)` return, so on
desktop Ctrl/Cmd+P has no dialog to open. The keydown handler still runs and
calls `preventDefault`, which is why the chord reads as dead rather than as
unbound.
Mount it beside the other always-mounted dialogs in the desktop return. They
portal out, so tree position does not matter — the comment above that block
already says so for the two dialogs already there.
Model: claude-opus-5[1m]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{fileQuickOpenDialog}is mounted only inside theif (isMobile)return, so ondesktop Ctrl/Cmd+P has no dialog to open. The keydown handler still runs and
calls
preventDefault, which is why the chord reads as dead rather than asunbound.
Mount it beside the other always-mounted dialogs in the desktop return. They
portal out, so tree position does not matter — the comment above that block
already says so for the two dialogs already there.
Compatibility
Every change is additive at its default. With the new prop, parameter or flag
absent, the touched components render and behave exactly as they do today, and
no existing call site in this repository passes one.
Testing
packages/componentstypecheck and the full vitest suite pass. No new test:SessionDetailneeds a workspace runtime to mount.Notes for the reviewer
One line. The handler already runs and calls
preventDefault, which is why the chord reads as dead rather than as unbound.Review metadata
BlitzOS fork only. Delete this section before sending the PR to
LodyAI/Lody.blitz/seam-10-desktop-quick-open-dialogf3474894 (the pinned upstream commit)