fix(components): render the worktree glyph on SessionList rows - #18
Draft
pythonlearner1025 wants to merge 1 commit into
Draft
fix(components): render the worktree glyph on SessionList rows#18pythonlearner1025 wants to merge 1 commit into
pythonlearner1025 wants to merge 1 commit into
Conversation
`SessionRowWorktreeIndicator` is exported and rendered by `loro-app-sidebar.tsx` and `sidebar-updated-session-list.tsx`, but not by `SessionList` — although its rows already carry `isWorktree` from the session meta. A worktree session listed by `SessionList` therefore never shows the indicator. Render it in the row's metric cluster, in the same position `loro-app-sidebar.tsx` uses: to the left of the PR icon and to the right of the line diff. The cluster's render condition gains the same term, so a worktree row with no PR and no diff reaches it instead of falling to the time-only branch. The indicator renders null for a falsy `isWorktree`, so nothing changes for a non-worktree row. Model: claude-opus-5[1m]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionRowWorktreeIndicatoris exported and rendered byloro-app-sidebar.tsxand
sidebar-updated-session-list.tsx, but not bySessionList— although itsrows already carry
isWorktreefrom the session meta. A worktree session listedby
SessionListtherefore never shows the indicator.Render it in the row's metric cluster, in the same position
loro-app-sidebar.tsxuses: to the left of the PR icon and to the right of theline diff. The cluster's render condition gains the same term, so a worktree row
with no PR and no diff reaches it instead of falling to the time-only branch.
The indicator renders null for a falsy
isWorktree, so nothing changes for anon-worktree row.
Compatibility
Every change is additive at its default. With the new prop, parameter or flag
absent, the touched components render and behave exactly as they do today, and
no existing call site in this repository passes one.
Testing
packages/componentstypecheck and the full vitest suite pass. No new test: the row is inline JSX inside a virtualized list, and rendering it needs the sidebar's provider stack.tests/session-list-pr-badge.test.tsis the nearest existing shape and covers a different, extracted model.Notes for the reviewer
Placement is copied from
loro-app-sidebar.tsx, not chosen:[diff][worktree][PR]. The chat-group branch is deliberately untouched.Review metadata
BlitzOS fork only. Delete this section before sending the PR to
LodyAI/Lody.blitz/seam-9-session-list-worktree-glyphf3474894 (the pinned upstream commit)