feat(components): opt-in props for surfaces an embedding host does not serve - #16
Draft
pythonlearner1025 wants to merge 1 commit into
Draft
feat(components): opt-in props for surfaces an embedding host does not serve#16pythonlearner1025 wants to merge 1 commit into
pythonlearner1025 wants to merge 1 commit into
Conversation
…t serve Three groups of controls render on a hosted or single-member composition and cannot work there, and none of them has a capability that answers the question. Each is a new optional prop defaulting to today's behaviour; no existing call site passes any of them. - `SessionChatInterface.hideCloudMenuItems`, forwarded to `SessionHeaderMenu`: drops "Change owner", "Share with team" and "Copy URL". A single-member workspace has no second member to hand a session to, a host may serve sharing from its own chrome, and "Copy URL" builds a deep link and toasts success either way. Each row's existing gate (`owner`, `sharing`, `onCopyUrl`) answers a different question. - `SessionChatInterface.hideNotificationPrompt`: for a host that mounts no push provider, so Enable asks the browser for a permission nothing consumes. - `SessionChatInterface.hideAgentRoles` and `ChatLanding.hideAgentRoles`, both forwarded to the composer's run-config menu: for a workspace catalog with no Roles and no writer for one, where an empty list renders a "New role" entry opening an editor whose save has nowhere to land. - `ChatLanding.hideProductHints`: the hint band's `no-machine` state resolves `download-client` outside Electron, so a hosted surface tells the member to install the desktop app; `no-agent-config` offers "Go to Settings", which on a host that mounts no settings surface only flips an atom. - `SessionDetail.keyboardShortcutsAvailable`: the composer draws its ⌘L discovery chip from the `session.focusInput` registration, so a host that never calls `commands.attach(window)` advertises a chord nothing answers. Passed as `useCommand`'s existing second argument. `SessionDetail` declares and forwards the three chat-surface props to every surface it mounts. Model: claude-opus-5[1m]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three groups of controls render on a hosted or single-member composition and
cannot work there, and none of them has a capability that answers the question.
Each is a new optional prop defaulting to today's behaviour; no existing call
site passes any of them.
SessionChatInterface.hideCloudMenuItems, forwarded toSessionHeaderMenu:drops "Change owner", "Share with team" and "Copy URL". A single-member
workspace has no second member to hand a session to, a host may serve sharing
from its own chrome, and "Copy URL" builds a deep link and toasts success
either way. Each row's existing gate (
owner,sharing,onCopyUrl) answersa different question.
SessionChatInterface.hideNotificationPrompt: for a host that mounts no pushprovider, so Enable asks the browser for a permission nothing consumes.
SessionChatInterface.hideAgentRolesandChatLanding.hideAgentRoles, bothforwarded to the composer's run-config menu: for a workspace catalog with no
Roles and no writer for one, where an empty list renders a "New role" entry
opening an editor whose save has nowhere to land.
ChatLanding.hideProductHints: the hint band'sno-machinestate resolvesdownload-clientoutside Electron, so a hosted surface tells the member toinstall the desktop app;
no-agent-configoffers "Go to Settings", which on ahost that mounts no settings surface only flips an atom.
SessionDetail.keyboardShortcutsAvailable: the composer draws its ⌘Ldiscovery chip from the
session.focusInputregistration, so a host that nevercalls
commands.attach(window)advertises a chord nothing answers. Passed asuseCommand's existing second argument.SessionDetaildeclares and forwards the three chat-surface props to everysurface it mounts.
Compatibility
Every change is additive at its default. With the new prop, parameter or flag
absent, the touched components render and behave exactly as they do today, and
no existing call site in this repository passes one.
Testing
packages/componentstypecheck and the full vitest suite pass. No new test: every prop is a render guard inside a component that needs a workspace runtime.Notes for the reviewer
Companion to
blitz/seam-7-github-capability-gate, which is the half of this work that needed no prop because the capability already existed. These three groups have no capability that answers them, and inventing one per group would be a bigger claim than the suppression. Every prop defaults to today's behaviour and no existing call site passes one.keyboardShortcutsAvailableusesuseCommand's existing second argument, so it is one changed line.Review metadata
BlitzOS fork only. Delete this section before sending the PR to
LodyAI/Lody.blitz/seam-7-host-suppression-propsf3474894 (the pinned upstream commit)