fix(templates): explain a per-member connection instead of a bare checkbox - #65
Open
pythonlearner1025 wants to merge 1 commit into
Open
fix(templates): explain a per-member connection instead of a bare checkbox#65pythonlearner1025 wants to merge 1 commit into
pythonlearner1025 wants to merge 1 commit into
Conversation
…ckbox Picking Google Workspace, Linear or YouTrack on the template page produced a checkbox and nothing else — no button, no note, no hint that the member signs in later inside the workspace. The cause is one gate. Every note and button in the block hangs off `wantsOrgConfig`, which is `chosen !== null && entry.adminForm !== null`. Those three carry `adminForm: null` in the catalog, so the whole block was skipped for exactly the providers that most needed a word of explanation. They now render the sentence the org-key providers already use, so there is one phrasing rather than a second variant to keep in step. Also: the repo picker said "Set up GitHub above first" for what the surface calls connecting. It says "Connect GitHub above first" now. Both are pinned by tests that fail against the previous renderer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From annotations on
blitzos.com/templates/new. Covers items 1–4; the GitHubApp work (item 5) is deliberately not here.
The bug behind three of the four annotations
Google Workspace, Linear and YouTrack each rendered a checkbox and nothing
else when picked — no button, no note, no hint that the member signs in later
inside their workspace.
One gate causes all three. Every note and button in the connection block hangs
off:
and those three providers carry
adminForm: nullin the catalog(
google-workspace.ts:34,linear.ts:37,youtrack.ts:30), againstgithub.ts:39anddiscord.ts:25which do not. So the entire block was skippedfor exactly the providers that most needed a word of explanation.
They now render the sentence the org-key providers already use — "Members
sign in to X themselves." — rather than a second phrasing to keep in step.
The fourth annotation
The repo picker said "Set up GitHub above first" for what every other label on
the surface calls connecting. It now says "Connect GitHub above first".
Evidence
Both changes are pinned by tests that fail against the previous renderer:
The first is the existing per-member test, extended and renamed — its old name
promised only the absence of an admin form, which is no longer all it guards.
The second already existed and pinned the old string.
webapp
vitest: 299 pass.Not in this PR
Annotation 5 asks for a BlitzOS GitHub App: "Connect with BlitzOS app" beside
"Connect with my app", the latter replacing "Add GitHub key". That is an app
registration, an install callback, org and repo scoping, installation-token
minting, and a migration path for anyone already on a PAT. It needs decisions
before code and does not belong bolted onto a copy fix.
Not verified
No browser check — this sandbox has no local control plane. The assertions are
on rendered text through the real component, not on a screenshot.
🤖 Generated with Claude Code