ci: drop the Target B managed build job - #240
Merged
Merged
Conversation
The JavaScript job already runs the same eight managed-toolchain suites with BLITZDEV_MANAGED=1, and the emitter test imports the real emitter. The job's only extra work was the blitzdev:build command line. Target B is dormant until the blitz.dev platform lift. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01So15XYnmh9Hfx9xdNgG1Yu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What part this touches
.github/workflows/ci.ymlis the check matrix that runs on every push and pull request.packages/control-plane/scripts/build-blitzdev.mjs.Target B managed build (blitz.dev)job ran that emitter and eight vitest files underBLITZDEV_MANAGED=1.The gap
JavaScriptjob runsnpm testwithBLITZDEV_MANAGED=1. The same eight suites run there, closure gate included, andblitzdev-emitter.test.tsimports the real emitter.blitzdev:buildcommand line. It costs about 52 s per run, and the matrix runs twice per pull request.plans/BLITZDEV-PLATFORM-ASKS.mdsays its production promotion waits for a platform lift, and the emitter last changed in August.The fix
blitzdevjob and its comment block fromci.yml.blitzdev:buildscript stay in the tree.The risk trade
blitzdev:buildcommand line itself no longer runs in CI. The emitter module it calls is exercised byblitzdev-emitter.test.tsin the JavaScript job. If the command-line wrapper ever drifts from the module, the first person to run it finds out.Tests
node --test test/deploy-tooling.test.mjsinpackages/control-planeparses both workflows and passes.Deploy
🤖 Generated with Claude Code
https://claude.ai/code/session_01So15XYnmh9Hfx9xdNgG1Yu