Conversation
Likith101
requested review from
CascadingRadium,
Samsonnyyeet,
Thejas-bhat,
capemox,
maneuvertomars and
steveyen
June 30, 2026 13:52
| // that order) for the documents indexed, each indexed by geo docID. | ||
| DocScores() (innerScores, crossScores []uint64) | ||
| // BoundingBox returns the bounding box bytes for the given geo docID. | ||
| BoundingBox(geoDocID uint64) ([]byte, error) |
There was a problem hiding this comment.
Hey Likith,
Why are we representing geoDocID here using uint64, but CrossDocIDs returns geo docIDs as uint32.
Similar query for Shape(geoDocID uint64) ([]byte, error) too.
| Excluded() *roaring.Bitmap | ||
| // GetScoreMap returns an empty score map, keyed by geo docID, from a | ||
| // segment-level pool. | ||
| GetScoreMap() map[uint32]uint64 |
There was a problem hiding this comment.
Here as well and for PutScoreMap, noticing that geo docID is keyed as uint32 in the map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.