Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion blebox_uniapi/box.py
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,10 @@ async def async_ota_check(self) -> None:
await self._session.async_api_get_ota("/api/ota/check")
for _ in range(3):
await asyncio.sleep(1)
response = await self._session.async_api_get("/info")
try:
response = await self._session.async_api_get("/api/device/state")
except HttpError:
response = await self._session.async_api_get("/info")
if response is None:
raise UnsupportedBoxResponse("Device returned non-JSON response")
response = response.get("device", response)
Expand Down
18 changes: 18 additions & 0 deletions tests/test_box.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,3 +234,21 @@ async def test_async_ota_check_returns_silently_when_no_available_fv(
with patch("asyncio.sleep", new=AsyncMock()):
await box.async_ota_check()
assert box.available_firmware_version is None


async def test_async_ota_check_falls_back_to_info(mock_session, sample_data, config):
box = Box(mock_session, sample_data, config, None)
mock_session.async_api_get_ota = AsyncMock(return_value=None)
mock_session.async_api_get = AsyncMock(
side_effect=[
error.HttpError("Request to /api/device/state failed with HTTP 404"),
{"device": {"availableFv": "2.0", "fv": "1.5"}},
]
)
with patch("asyncio.sleep", new=AsyncMock()):
await box.async_ota_check()
mock_session.async_api_get.assert_has_calls(
[mock.call("/api/device/state"), mock.call("/info")]
)
assert box.available_firmware_version == "2.0"
assert box.firmware_version == "1.5"
Loading