Repository navigation
Read the release version from a VERSION file (1.2.0) - #15
Closed
pjhartlieb wants to merge 2 commits into
Closed
pjhartlieb wants to merge 2 commits into
pjhartlieb wants to merge 2 commits into
Conversation
…a package manifest release-check and stable-guard read the version only from pyproject.toml (or through it) or Cargo.toml, so a Go or Docker-only repository (bbot-io-developer-portal) had no way to release. A root VERSION file now supplies it when there is no manifest version. Where both exist they must agree, as chart versions must, so the file cannot drift. Tests cover a VERSION-only repository, a prerelease in VERSION, a mismatch, a match, and the error that names the missing source.
Contributor
Author
|
Replaced by #16, the same two commits from a branch in this repository: CodeQL default setup does not scan pull requests from forks, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-checkandstable-guardread the release version only from the package manifest (pyproject.toml, or through itCargo.toml). A Go or Docker-only repository has neither, so it can't release through these workflows. bbot-io-developer-portal is the first. Its version now lives only in its publish job's image tags.manifest.pynow falls back to aVERSIONfile at the repository root when there is no manifest version:VERSION: that is the release version, under the same MAJOR.MINOR.PATCH, chart and git-dependency checks.Nothing changes for existing callers, which all have a manifest version, so this is a minor version: 1.2.0.
Tests: five new cases (VERSION only, a prerelease in VERSION, a mismatch, a match, neither). 46 pass. Against the old
manifest.py, four of the five new tests fail; the fifth guards that a matching VERSION file changes nothing.ruffclean;zizmor1.30.1 (online audits) andactionlint1.7.12 report nothing.