-
Notifications
You must be signed in to change notification settings - Fork 0
Test coverage for codesigned updates #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ofalvai
wants to merge
1
commit into
master
Choose a base branch
from
push-qntptxzvpzzy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| "use strict"; | ||
|
|
||
| import crypto = require("crypto"); | ||
| import fs = require("fs"); | ||
| import mkdirp = require("mkdirp"); | ||
| import path = require("path"); | ||
|
|
||
| import { Platform, ProjectManager, ServerUtil, setupUpdateScenario, TestConfig, TestUtil } from "code-push-plugin-testing-framework"; | ||
|
|
||
| const CODEPUSH_METADATA_FILE_NAME = ".codepushrelease"; | ||
|
|
||
| function isHashIgnored(relativePath: string): boolean { | ||
| return relativePath.startsWith("__MACOSX/") | ||
| || relativePath === ".DS_Store" | ||
| || relativePath.endsWith("/.DS_Store") | ||
| || relativePath === CODEPUSH_METADATA_FILE_NAME | ||
| || relativePath.endsWith(`/${CODEPUSH_METADATA_FILE_NAME}`); | ||
| } | ||
|
|
||
| /** | ||
| * Computes the same content hash that the native SDKs compute over an installed update folder, so the mock server | ||
| * can hand back a package_hash that will actually match what the client expects. | ||
| */ | ||
| export function computeUpdateContentsHash(folderPath: string): string { | ||
| const manifest: string[] = []; | ||
|
|
||
| const walk = (currentPath: string, relativePrefix: string) => { | ||
| for (const entryName of fs.readdirSync(currentPath)) { | ||
| const entryPath = path.join(currentPath, entryName); | ||
| const relativePath = relativePrefix ? `${relativePrefix}/${entryName}` : entryName; | ||
|
|
||
| if (isHashIgnored(relativePath)) { | ||
| continue; | ||
| } | ||
|
|
||
| if (fs.statSync(entryPath).isDirectory()) { | ||
| walk(entryPath, relativePath); | ||
| } else { | ||
| const fileHash = crypto.createHash("sha256").update(fs.readFileSync(entryPath)).digest("hex"); | ||
| manifest.push(`${relativePath}:${fileHash}`); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| walk(folderPath, ""); | ||
| manifest.sort(); | ||
|
|
||
| return crypto.createHash("sha256").update(JSON.stringify(manifest)).digest("hex"); | ||
| } | ||
|
|
||
| const codeSigningPrivateKey = fs.readFileSync(path.join(__dirname, "../test/fixtures/codesigning/test-private-key.pem"), "utf8"); | ||
| export const codeSigningPublicKey = fs.readFileSync(path.join(__dirname, "../test/fixtures/codesigning/test-public-key.pem"), "utf8").trim(); | ||
|
|
||
| function base64UrlEncode(input: Buffer): string { | ||
| return input.toString("base64").replace(/\+/g, "-").replace(/\//g, "_").replace(/=+$/, ""); | ||
| } | ||
|
|
||
| /** | ||
| * Builds the RS256-signed ".codepushrelease" JWT that the native SDKs look for inside an update | ||
| * archive's "CodePush/" folder. | ||
| */ | ||
| function signUpdateContentsHash(contentHash: string): string { | ||
| const header = base64UrlEncode(Buffer.from(JSON.stringify({ alg: "RS256", typ: "JWT" }))); | ||
| const payload = base64UrlEncode(Buffer.from(JSON.stringify({ contentHash }))); | ||
| const signature = base64UrlEncode(crypto.sign("RSA-SHA256", Buffer.from(`${header}.${payload}`), codeSigningPrivateKey)); | ||
| return `${header}.${payload}.${signature}`; | ||
| } | ||
|
|
||
| /** | ||
| * Code-signs the update contents with the test key pair and records the real hash, so the mock | ||
| * server hands back a package_hash that matches what the client's data-integrity check computes. | ||
| */ | ||
| export function signAndRecordUpdateArchive(bundleFolder: string, isDiff: boolean): void { | ||
| // TODO(RA-4875): Diff updates clear it instead, since they are poorly implemented in the entire test harness. | ||
| // It's going to be a bigger refactor, so for now we just skip signing/hashing to avoid using a stale value in diff tests. | ||
| if (isDiff) { | ||
| ServerUtil.setKnownPackageHash(undefined); | ||
| return; | ||
| } | ||
|
|
||
| const contentHash = computeUpdateContentsHash(bundleFolder); | ||
| const signatureFolder = path.join(bundleFolder, "CodePush"); | ||
| mkdirp.sync(signatureFolder); | ||
| fs.writeFileSync(path.join(signatureFolder, CODEPUSH_METADATA_FILE_NAME), signUpdateContentsHash(contentHash)); | ||
| ServerUtil.setKnownPackageHash(contentHash); | ||
| } | ||
|
|
||
| export async function setupTamperedSignatureUpdateScenario(projectManager: ProjectManager, targetPlatform: Platform.IPlatform, scenarioJsPath: string, version: string): Promise<string> { | ||
| const updatePath = await setupUpdateScenario(projectManager, targetPlatform, scenarioJsPath, version); | ||
|
|
||
| const bundleFolder = path.join(TestConfig.updatesDirectory, TestConfig.TestAppName, "CodePush/"); | ||
| const tamperedHash = "0".repeat(64); | ||
| fs.writeFileSync(path.join(bundleFolder, "CodePush", CODEPUSH_METADATA_FILE_NAME), signUpdateContentsHash(tamperedHash)); | ||
|
|
||
| return await TestUtil.archiveFolder(bundleFolder, "", updatePath, false); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| -----BEGIN RSA PRIVATE KEY----- | ||
| MIIEpQIBAAKCAQEApZtuvtGcQmmeUh81n/jAjeDkktkX1QryINqRZrcoofjw+w89 | ||
| FdW3XxQOhsjIJLr5u0xqjHde6Hzpx9sbcUGivmW1O0HBuCsAeiVHyiTq/t+sEiKP | ||
| 0VZa1mbnSM3EEQl09Si3NpLs4sHK+uvttLT3KEZy+Zhx54gaM5iz7ErqavpDADaW | ||
| DWplIXUK/D/pQulbM1oM+04V1XkKw5bBqEHTi6Whq/YUPWs2+7KXyLnvKyO+33YF | ||
| WnHhHGbGkGLYE02sAGonYgaP220vJ4lnwLx0OcEagfdlM8YwfyOUSWn7LB0VCJaz | ||
| ltDiuM1ZhL1rDA8d0rHZvtxKJDLz3uIRuppj7wIDAQABAoIBAAIEOH7+UmbEnnbl | ||
| hmOiRcX0fRQErLOdZIFd5/NWO5ptS5HjB51ics8nkV22yCkaVbwgHBQFyBQQoVAb | ||
| rOPeJrsmxeQo0tEJRQI3vf4KIQplctTtss6bvJNrwVkzmDWU5eWuTzzM4TGJpo0T | ||
| nlta8L9+zBuZ7ZkiIR+LtnUkHGKdEHKFD4melmeZrvMCDNTGrpa2Y2bP9I11a6xZ | ||
| V1XJIxvAQRftorz03vsQXFiIcscEaho65DiAObSqpn1tfFnTbPOl+z4XjKncAVF8 | ||
| 5vmkVHvERnvUuuBmSTEgGrEcCgwmYKxtOGqWw3MpeP9DWroU5T1N/Mx5xTr3GID5 | ||
| 6T3+bMECgYEA6Kyg43UCouS7LD/lB5z0dflK8Wu0hzdYUR58r4e2S/WhzkiyX1rZ | ||
| aJNkrxyC8/39lGrYdfJHc+RNbViC1TMfH7Zao1lNFVP7vF70v2HzishCL95wSXNz | ||
| KZnSY3Yac1ONVP8ZbxX20QBXh9aoTsQxtOs15+XBvOXA5kJwtaaPgTECgYEAtjWW | ||
| UiLznuODzIyOQugysXN9bU0UTqUxr3QDt0yqCjA0URVlf3Ehi7OVUPerVSwgCD5m | ||
| 4RXltW8pqMCLY/qPLkVFH+uZJ/Oo495TEMbyk2/4GXEX4klBMW40YI5srFtP95k+ | ||
| HrW5+gFOoVLcpwxRHcW6JateA7RlZDReruAt7x8CgYEAgcQdqx4MTVsyRNiR3LAd | ||
| 61oRARpnwe4NFJjjQ2Z2NmEVUB5dVS8vB9MEmWFWa8whTFBWz1lDnpAa2rw9o7hy | ||
| SFaEsIvSoO2I/aMb700q7iEIQPhXOa/o76+5lf09fUqBDYGE5t6iHCiLqNgAYIWt | ||
| j1CLbP1IExk0f3dYswblDFECgYEAkib5pHiUoWYtWe2ETvahcuUIPpwNJegrqmiM | ||
| coL0AagYztEy0L6WAdDSfFes/myeZP5o1zMRRi8cY1fOdyuLnbnCcJAyEXHIjr7O | ||
| Mi7idJDjmMS2O7Q2rsePC8QyNy4nPpuU0F1EB9z0jUJB61xd1Fu9rGmAx8fzbCT1 | ||
| rZ/0OFECgYEAwQHaF2oxQMxd/WzuTHtKYuPAJDvONQj+hcEAEVFUGEVnauRoUuta | ||
| rhgnWrD2rte/6JqGPnfJouW+w1Y+2Mnfp4io8/cyysiEX7VWTeZL+nUERczTserl | ||
| cyujq12LNdD+YPQwJTxHguP0rbMsQ2lHlxwys1+74GGq7GqR3dIJlqc= | ||
| -----END RSA PRIVATE KEY----- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| -----BEGIN PUBLIC KEY----- | ||
| MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEApZtuvtGcQmmeUh81n/jA | ||
| jeDkktkX1QryINqRZrcoofjw+w89FdW3XxQOhsjIJLr5u0xqjHde6Hzpx9sbcUGi | ||
| vmW1O0HBuCsAeiVHyiTq/t+sEiKP0VZa1mbnSM3EEQl09Si3NpLs4sHK+uvttLT3 | ||
| KEZy+Zhx54gaM5iz7ErqavpDADaWDWplIXUK/D/pQulbM1oM+04V1XkKw5bBqEHT | ||
| i6Whq/YUPWs2+7KXyLnvKyO+33YFWnHhHGbGkGLYE02sAGonYgaP220vJ4lnwLx0 | ||
| OcEagfdlM8YwfyOUSWn7LB0VCJazltDiuM1ZhL1rDA8d0rHZvtxKJDLz3uIRuppj | ||
| 7wIDAQAB | ||
| -----END PUBLIC KEY----- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from
test.ts, not new code