Skip to content

(commands) add well-known commands for setting and disk operations - #268

Merged
kattrali merged 2 commits into
mainfrom
delisa/bit-10069-disk-operations-settings
Nov 16, 2026
Merged

kattrali merged 2 commits into
mainfrom
delisa/bit-10069-disk-operations-settings

Conversation

@kattrali

@kattrali kattrali commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Add commands for viewing/modifying settings and the app cache

@kattrali
kattrali force-pushed the delisa/bit-10069-disk-operations-settings branch 2 times, most recently from d00ad39 to e916532 Compare November 11, 2026 14:17
@kattrali
kattrali force-pushed the delisa/bit-10069-disk-operations-settings branch from e916532 to 753dca9 Compare November 12, 2026 15:12
@kattrali
kattrali marked this pull request as ready for review November 12, 2026 15:13
Comment on lines +387 to +388
FILE_LIST = 8 [(well_known_command_options) = {
key: "file_list"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file commands are named broadly to support later adding an optional argument to handle other file areas

description: "Settings key to remove"
},
{
name: "file_name"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this and the other NSUserDefaults/UserDefaults commands: wouldnt be also good to have this parameter (or a separate one with a more specific name) for the suiteName (more info)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda wondered something similar, though the semantics are weird, especially for mac apps, where you can use it to access other apps' settings

@kattrali
kattrali force-pushed the delisa/bit-10069-disk-operations-settings branch from 753dca9 to a7e9384 Compare November 16, 2026 11:47
@kattrali
kattrali merged commit 9c4c573 into main Nov 16, 2026
2 checks passed
@kattrali
kattrali deleted the delisa/bit-10069-disk-operations-settings branch November 16, 2026 11:49
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants