Repository navigation
(commands) add well-known commands for setting and disk operations - #268
Merged
Merged
Conversation
kattrali
force-pushed
the
delisa/bit-10069-disk-operations-settings
branch
2 times, most recently
from
November 11, 2026 14:17
d00ad39 to
e916532
Compare
kattrali
force-pushed
the
delisa/bit-10069-disk-operations-settings
branch
from
November 12, 2026 15:12
e916532 to
753dca9
Compare
kattrali
marked this pull request as ready for review
November 12, 2026 15:13
kattrali
commented
Nov 12, 2026
Comment on lines
+387
to
+388
| FILE_LIST = 8 [(well_known_command_options) = { | ||
| key: "file_list" |
Contributor
Author
There was a problem hiding this comment.
The file commands are named broadly to support later adding an optional argument to handle other file areas
| description: "Settings key to remove" | ||
| }, | ||
| { | ||
| name: "file_name" |
Contributor
There was a problem hiding this comment.
For this and the other NSUserDefaults/UserDefaults commands: wouldnt be also good to have this parameter (or a separate one with a more specific name) for the suiteName (more info)?
Contributor
Author
There was a problem hiding this comment.
I kinda wondered something similar, though the semantics are weird, especially for mac apps, where you can use it to access other apps' settings
ArielDemarco
approved these changes
Nov 12, 2026
kattrali
force-pushed
the
delisa/bit-10069-disk-operations-settings
branch
from
November 16, 2026 11:47
753dca9 to
a7e9384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add commands for viewing/modifying settings and the app cache