test: listen_tests and connect_tests follow-ups - #344
Open
xyzconstant wants to merge 9 commits into
Open
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process. |
Use the existing `SocketPair()` helper directly in each test instead of the `init_sockets` callback and fd members, which nothing else in the class used.
Move it to a common.h file. The connect_tests copy previously didn't log messages, now it does through the shared version.
Unnecessary since the tests are inside the mp namespace.
The conditional served no purpose and leaked the descriptor when `recv()` failed or returned zero.
xyzconstant
force-pushed
the
listenconnections-and-connectstream-tests-follow-ups
branch
from
August 13, 2026 04:17
76ab72f to
c39c785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review suggestions left (all of them made by @ryanofsky) in the now-merged PRs #298 and #310.
These are non-critical test cleanups (naming, simplification, comments, etc.) with zero changes to library code.