Bump urllib3 from 2.3.0 to 2.5.0 - #10
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
--- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
Author
|
Superseded by #29. |
NovrusShehaj
pushed a commit
to NovrusShehaj/platform
that referenced
this pull request
Aug 3, 2026
…eview biosimulations#14 (worker pod disk leak) -- wrap biosim_service.run_biosim_sim in try/finally inside submit_biosim_run_activity so local_omex_path is always removed, even when submit raises (HTTP 5xx, network, auth). The os.remove is itself wrapped in try/except OSError so a missing-file race during cleanup is non-fatal. biosimulations#5 (FAILED-row cache pollution) -- gate insert_biosimulator_workflow_run in poll_biosim_run_activity on `simulation_run.status == SUCCEEDED`. Non-SUCCEEDED runs still return a fully-populated (un-saved) BiosimulatorWorkflowRun so OmexSimWorkflow can surface the FAILED state -- the workflow does not consult database_id. Eliminates unbounded BiosimSims growth on failing inputs and removes the cache-lookup ordering hazard (cached_runs[0] could otherwise be a FAILED row hiding a later SUCCEEDED one). biosimulations#10 (missing Mongo indexes) -- add an ensure_indexes() method to all three Mongo DB services (default no-op on the abstract base; Mongo impls override). Called from init_standalone() and from each test fixture so production and tests share the same shape. Indexes: BiosimSimulationRuns: processing_id, run_id (unique) BiosimSims: (file_hash_md5, image_digest, cache_buster) compound + biosim_run.id BiosimOmex: file_hash_md5 (non-unique; the check-then-insert callers don't handle DuplicateKeyError, so uniqueness stays logical). #2 (status 404 after workflow history eviction) -- restructure GET /simulations/{processing_id}: don't 404 when the workflow query raises. Try the SimulationRunRecord DB fallback; only 404 if both sources are empty. A new _conglomerate_status_from_records helper builds ConglomerateStatus from persisted records when the workflow is gone (mapping CREATED/SUCCEEDED/FAILED back to processing/success/failure). Tests: 3 new router tests cover the workflow-not-found-with-DB-fallback path, the both-empty 404, and the hybrid enrichment-from-DB path. Existing test_get_simulation_status_not_found still passes (no records -> 404). Full -m "not integration" gate: 83 passed, 1 failed (the pre-existing test_slurm_service env failure, unchanged). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.