Copilot/sync rabbit data - #23
Open
5hy7xz92nd-oss wants to merge 169 commits into
Open
Conversation
…test-run-develop-repeat Add repository-wide PoC validation and regression coverage
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
…phic-blueprint
…ck-merge-into-13
…zed-architecture
…evelopment-101
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 17 changed files in this pull request and generated no new comments.
Suppressed comments (4)
validate_pocs.py:11
Tupleis imported but never used; this can trigger lint/type-check failures and makes the module look unfinished. Remove the unused import (or use it if intended).
from typing import List, Dict, Tuple
tests/test_validate_pocs.py:18
- This test is brittle: asserting
len(python_targets) > 20will fail as the repo grows/shrinks even when discovery is correct. Prefer only asserting non-empty discovery and/or presence of a stable known target.
self.assertTrue(any(path.name == "run_demo.py" for path in python_targets))
self.assertTrue(any(path.name == "package.json" for path in package_targets))
self.assertGreater(len(python_targets), 20)
self.assertGreater(len(package_targets), 0)
.github/instructions/*.instructions.md:5
- This new Copilot instructions file appears to contain large amounts of non-instructional/log-like content (mentions, repeated ASCII art, and external chat links). Keeping this in
.github/instructionsrisks prompt-injection style behavior and makes repository instructions hard to review and maintain. Consider removing it, or replacing it with a short, task-focused set of instructions under a normal filename (avoid*in filenames, which breaks checkouts on Windows/filesystems that disallow it).
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
validate_pocs.py:14
discover_*_targets()only excludes.gitand__pycache__, so it will also traverse common local/CI artifact directories likenode_modules/and virtualenvs (several PoC folders already ignore.venv/venvandnode_modulesin their.gitignore). This can significantly slow validation and may surface irrelevant errors from installed dependencies. ExpandEXCLUDED_DIRSto skip those artifact directories.
EXCLUDED_DIRS = {".git", "__pycache__"}
…phic-blueprint Merge pull request #36 from 5hy7xz92nd-oss/main
…s table Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 17 changed files in this pull request and generated no new comments.
Suppressed comments (2)
validate_pocs.py:11
Tupleis imported but never used, which can trigger linter failures and adds noise to the module imports.
from typing import List, Dict, Tuple
tests/test_validate_pocs.py:18
- These tests are coupled to the current repository contents (expects specific filenames and minimum counts, and asserts the whole repo validates cleanly). This will become flaky as PoCs are added/removed or if the repo intentionally contains non-compiling examples; prefer testing against a temporary directory fixture with controlled files.
self.assertTrue(any(path.name == "run_demo.py" for path in python_targets))
self.assertTrue(any(path.name == "package.json" for path in package_targets))
self.assertGreater(len(python_targets), 20)
self.assertGreater(len(package_targets), 0)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…e-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.