Repository navigation
Tests pass as root; CI runs once per commit, translation job only in biglinux - #63
Merged
Merged
Conversation
CI runs in an archlinux container as root, and root ignores a read-only folder: the history was saved and test_unwritable_folder_is_reported_not_raised failed. The folder is now made impossible by giving it a regular file as parent, which stops root too.
test: unwritable history folder also when tests run as root
- CI ran every pull request twice: once for the push to its branch and once for the pull_request event. Pushes now trigger it only on main; a newer commit cancels the run it replaces. - Translate and Build Package runs only in the biglinux organization. Forks lack the translation keys and the builder token: the translation step hung until GitHub's 6-hour limit. It now has a 90-minute timeout, and runs on the same branch queue instead of pushing over each other.
ci: one run per commit, no translation/build jobs in forks
ruscher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests as root
CI (archlinux container) runs the tests as root, and root ignores the
chmod 0o500the tests used to make the Music folder read-only. Sotest_unwritable_folder_is_reported_not_raisedfailed: the history was saved.That test, and
test_history_folder_without_permission_never_breaks_reading, now give the history folder a regular file as its parent, which stops root too.Workflows
pull_request. Push now triggers it only onmain, and a newer commit cancels the run it replaces.github.repository_owner == 'biglinux'. In forks, which have no translation keys or builder token, it hung until the 6-hour limit. Upstream behavior is unchanged, plus a 90-minute timeout and one run per branch at a time.Verified:
podman unshare,LC_ALL=C): 265 passed;