Repository navigation
fix(build): check() passes on the BigLinux builder - #62
Merged
Merged
Conversation
- "Read or stop the selected text" was inside f-strings: the translation bot's xgettext does not look there, dropped it from the .pot and test_pot_lists_every_string failed. _() now sits outside the f-strings, the string is back in the .pot, and a test rejects _() in f-strings. - The builder runs with LC_ALL=C, which wins over the LANG the language tests set: they now clear LC_ALL/LC_MESSAGES.
fix(build): check() passes on the BigLinux builder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BigLinux builder failed in
check()(pipeline 37319) on two tests.test_pot_lists_every_string: "Read or stop the selected text" was passed to_()inside f-strings. The translation bot'sxgettextdoes not look inside f-strings, so it dropped the string from the.pot._()is now called outside the f-strings, in both places..pot;xgettextnow extracts it._()inside f-strings, so this is caught locally before the bot runs.test_espeak_voice_unknown_uses_system: the builder runs withLC_ALL=C, which wins over theLANG=pt_BRthe test sets. The language tests now clearLC_ALL/LC_MESSAGES.The bot's commit
translate 26-10-09_00:09only removed blank lines from the.pofiles. Parsed catalogs are identical before and after it (375 strings per language).Verified:
LC_ALL=C: 265 passed;makepkgunderLC_ALL=C: check() 261 passed, 1 skipped;sync_translations --checkpasses.