Skip to content

fix: don't exclude sdks/ from Docker build context - #77

Open
sidequest-sophie wants to merge 2 commits into
bigint:mainfrom
sidequest-sophie:fix/dockerignore-sdks-typescript
Open

fix: don't exclude sdks/ from Docker build context#77
sidequest-sophie wants to merge 2 commits into
bigint:mainfrom
sidequest-sophie:fix/dockerignore-sdks-typescript

Conversation

@sidequest-sophie

@sidequest-sophie sidequest-sophie commented Jul 15, 2026

Copy link
Copy Markdown

Existing **/node_modules/, **/dist/, **/.turbo/ etc. rules already exclude build artifacts under sdks/, so removing the blanket rule doesn't reintroduce bloat.

Changes

  • Removed the blanket sdks/ line from .dockerignore, so sdks/typescript is available in the Docker build context for the bigrag-ui build.

Related issues

Closes #76

Verification plan

  • Fresh clone + docker compose up -d succeeds; bigrag-api, bigrag-ui, postgres, and redis all come up healthy.
  • pnpm lint passes
  • cd api && uv run ruff check . && uv run ruff format --check . passes
  • Relevant typecheck, build, and runtime smoke checks completed
  • Docs updated (website/content/docs/) if user-facing behavior changed

Notes for reviewers

Single-line .dockerignore change. No code, docs, or lint-relevant files touched — the checklist items above beyond the fresh-clone build test shouldn't be affected, but leaving them unchecked for reviewer visibility rather than assuming.

Greptile Summary

This PR restores the TypeScript SDK to the Docker build context while keeping Python SDK files excluded. The main changes are:

  • Replaces the blanket sdks/ exclusion with sdks/python/.
  • Allows the UI image to copy sdks/typescript.
  • Keeps sdks/python/.venv out of root Docker build contexts.

Confidence Score: 5/5

This looks safe to merge.

  • The targeted rule excludes the full Python SDK subtree, including local virtual environments.
  • The TypeScript SDK remains available to the root-context UI build.
  • No blocking issues were found in the updated rule.

Important Files Changed

Filename Overview
.dockerignore Narrows the SDK exclusion to Python so the UI build can access the TypeScript SDK.

Reviews (2): Last reviewed commit: "Update .dockerignore" | Re-trigger Greptile

Context used:

  • Context used - AGENTS.md (source)

.dockerignore excluded the entire sdks/ directory, but app/Dockerfile
copies sdks/typescript into the bigrag-ui build. This breaks
'docker compose up -d' on a fresh clone with:

  failed to calculate checksum of ref ...: "/sdks/typescript": not found

Existing **/node_modules/, **/dist/, **/.turbo/ etc. rules already
exclude build artifacts under sdks/, so removing the blanket rule
doesn't reintroduce bloat.
Comment thread .dockerignore
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker compose up -d fails: sdks/typescript excluded by .dockerignore, breaks bigrag-ui build

1 participant