fix: don't exclude sdks/ from Docker build context - #77
Open
sidequest-sophie wants to merge 2 commits into
Open
Conversation
.dockerignore excluded the entire sdks/ directory, but app/Dockerfile copies sdks/typescript into the bigrag-ui build. This breaks 'docker compose up -d' on a fresh clone with: failed to calculate checksum of ref ...: "/sdks/typescript": not found Existing **/node_modules/, **/dist/, **/.turbo/ etc. rules already exclude build artifacts under sdks/, so removing the blanket rule doesn't reintroduce bloat.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing
**/node_modules/,**/dist/,**/.turbo/etc. rules already exclude build artifacts undersdks/, so removing the blanket rule doesn't reintroduce bloat.Changes
sdks/line from.dockerignore, sosdks/typescriptis available in the Docker build context for thebigrag-uibuild.Related issues
Closes #76
Verification plan
docker compose up -dsucceeds;bigrag-api,bigrag-ui,postgres, andredisall come up healthy.pnpm lintpassescd api && uv run ruff check . && uv run ruff format --check .passeswebsite/content/docs/) if user-facing behavior changedNotes for reviewers
Single-line
.dockerignorechange. No code, docs, or lint-relevant files touched — the checklist items above beyond the fresh-clone build test shouldn't be affected, but leaving them unchecked for reviewer visibility rather than assuming.Greptile Summary
This PR restores the TypeScript SDK to the Docker build context while keeping Python SDK files excluded. The main changes are:
sdks/exclusion withsdks/python/.sdks/typescript.sdks/python/.venvout of root Docker build contexts.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "Update .dockerignore" | Re-trigger Greptile
Context used: