Skip to content

Resolve open non-Samba discussions - #151

Merged
bifrost0x merged 2 commits into
mainfrom
dev/resolve-open-discussions
Aug 26, 2026
Merged

Resolve open non-Samba discussions#151
bifrost0x merged 2 commits into
mainfrom
dev/resolve-open-discussions

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • add a localized Duplicate action that opens a new saved-connection draft with all editable source settings and a bounded copy-name suffix
  • add action-bound, audited global known_hosts import with strict one-line validation, duplicate/conflict handling, and no raw key material in API responses
  • display bounded SSH authentication banners for targets and jump hosts before any forwarding channel, shell, tmux probe, or startup command opens; fail closed on decline, disconnect, or timeout
  • add explicit Passkey-backed MFA activation so enrolling a Passkey no longer leaves an unnoticed password-only fallback, including one-time recovery-code generation
  • document the exact Passkey login/MFA modes, global host-trust workflow, SSH protocol banner timing, and profile duplication behavior

Discussions

The Samba discussion is intentionally out of scope. This PR also does not introduce an administrator-enforced MFA mandate: a safe global mandate still needs enrollment grace periods, recovery/break-glass rules, and explicit handling for service and directory-managed accounts.

Verification

  • Python: 2,179 passed, 29 skipped in the full sandboxed suite; the 4 loopback-socket tests excluded by the sandbox all passed separately outside it
  • Targeted regression suite: 108 passed
  • JavaScript: all 32 test files passed
  • git diff --check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 603563e182

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/socket_events.py
Comment thread app/host_key_store.py
@bifrost0x
bifrost0x merged commit 9041518 into main Aug 26, 2026
16 of 17 checks passed
@bifrost0x
bifrost0x deleted the dev/resolve-open-discussions branch August 26, 2026 09:43
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant