Skip to content

Fix SFTP panel restoration and Paper Ops contrast - #132

Merged
bifrost0x merged 2 commits into
mainfrom
fix/issues-130-131-ui-regressions
Aug 22, 2026
Merged

Fix SFTP panel restoration and Paper Ops contrast#132
bifrost0x merged 2 commits into
mainfrom
fix/issues-130-131-ui-regressions

Conversation

@bifrost0x

@bifrost0x bifrost0x commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve the active embedded SFTP target while the full File Manager is open and restore it when the modal closes
  • let SFTPFileManager own Escape handling so the source launcher closes before the modal and embedded Files is restored
  • keep manual close, active-session changes, and disconnects authoritative during that handoff
  • resolve shared WebSSH 2 theme aliases against the active body theme so Paper Ops settings text remains readable
  • add focused unit and Playwright regressions for both reported paths and the reviewed Escape sequence

Root cause

Opening the full File Manager dispatched the same event as a manual embedded-SFTP close, so the workspace persisted a closed preference and never remounted the embedded manager body. The page-level Escape handler also closed the lazily created File Manager directly before its own handler could consume Escape for the source launcher, bypassing SFTPFileManager.close() and the embedded restore path.

Separately, the shared --ws2-* aliases were computed on :root before the Paper Ops variables applied on body[data-theme], leaving light Paper surfaces with dark-theme text values.

Validation

  • npm run lint:js
  • npm run test:js — 286 passed
  • npm run vendor:check — 10 assets verified
  • Python 3.14 targeted UI suite — 71 passed
  • npx playwright test tests/e2e/theme-system.spec.js tests/e2e/session-workspace.spec.js --forbid-only — 20 passed
  • independent follow-up diff review — no findings
  • git diff --check origin/main...HEAD

Fixes #130
Fixes #131

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4bae0dde5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/js/sftp-file-manager.js
@bifrost0x
bifrost0x merged commit 659c35a into main Aug 22, 2026
15 of 16 checks passed
@bifrost0x
bifrost0x deleted the fix/issues-130-131-ui-regressions branch August 22, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paper Ops theme unusable SFTP pane empty after using File Manager

1 participant