Restore the public polyad() method - #284
Open
afonsojanu wants to merge 1 commit into
Open
Conversation
polyad(number) was commented out back when 1.6.0's ESM publish was still in flux, gated on issue bgrins#254 as a temporary measure. That issue closed once 1.6.0 shipped, but nobody went back and uncommented the method or removed the ignore flag on its test, so it's been silently unreachable on master and in the published package ever since. Calling tinycolor("red").polyad(3) throws "polyad is not a function" even though the internal helper backing it, and the triad()/tetrad() methods built on top of the same helper, all work fine. Uncommented the method in mod.js and dropped the ignore: true from its Deno test, which already had the full 9-assertion spec written and waiting. Ran the full local suite (deno test test.js): 46 passed, 0 failed, including all the polyad assertions. Didn't touch the generated npm/dist bundles since those come out of the repo's own build step (deno task build), which needs network access to a couple of external packages that isn't available here to reproduce cleanly - the source change is the same either way, and running the build is presumably already part of the release process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281.
polyad(number) got commented out in mod.js while 1.6.0's ESM publish was still bumpy, gated on #254 as a temporary measure ("Disabled until #254"). #254 closed once 1.6.0 shipped, but the disable was never reverted and the method's test kept its
ignore: trueflag, so there's been no CI signal that it's missing. Callingtinycolor("red").polyad(3)on current master or the published package throwspolyad is not a function, even though the internal helper it delegates to, and triad()/tetrad() which use that same helper, both work fine.Uncommented the method and removed the ignore flag from its test, which already had the full assertion set written (throws on invalid input, correct hex output for 1 through 5 colors). Ran the local suite with
deno test test.js: 46 passed, 0 failed.One thing I didn't do: regenerate npm/dist.
deno task buildneeds network access to a couple of external packages I couldn't reach cleanly in this environment, so I left those alone - the source-level fix is the same regardless, and presumably the build already runs as part of cutting a release.