Repository navigation
[BY-3684]: type HttpError.status as number | undefined - #51
Merged
Merged
Conversation
status is absent when the request never got a response, but the generated d.ts declared number. Consumers surface the error via e.status ?? e.body?.statusCode ?? 500 and need the type to reflect that.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpError.statusis absent when the request never got a response, but the generateddist/index.d.tsdeclared it asnumber(tsconfig runs withstrict: false, so the optional constructor param collapses tonumberin emitted types).Consumers (e.g. the marketing app's
surfaceErrordefault handler) rely on a fallback chaine.status ?? e.body?.statusCode ?? 500that only makes sense ifstatuscan genuinely beundefined.Change
this.statusas@type {number | undefined}inlib/index.jsstatus: number | undefinedValidation
pnpm build: d.ts verifiedpnpm test: 74 passingeslint lib/index.js: cleanRefs BY-3684