Repository navigation
Add world.inspect methods to the Bevy Remote Protocol - #25883
Merged
alice-i-cecile merged 4 commits intoSep 25, 2026
Merged
Conversation
jbuehler23
force-pushed
the
jackdaw/inspector-brp-verbs
branch
from
September 22, 2026 15:01
cc2510d to
537c65e
Compare
jbuehler23
force-pushed
the
jackdaw/inspector-brp-verbs
branch
from
September 22, 2026 16:16
537c65e to
448a6a5
Compare
jbuehler23
force-pushed
the
jackdaw/inspector-brp-verbs
branch
from
September 24, 2026 07:54
8977af0 to
4b15930
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2026
hymm
reviewed
Sep 25, 2026
Member
|
Let me know when CI is green :) |
Contributor
Author
All good now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #25866. Review the last commit only pls!
Objective
Part of #23013.
Expose the inspection backend over the Bevy Remote Protocol so remote tools get labels, metadata, display strings and structured values from one call instead of assembling them from raw queries.
Ported from feathers_inspector, phase 5 of the upstreaming strategy there. The BRP module was originally written by @Nilirad.
Solution
Seven instant methods in a new inspection methods module, registered with the other defaults.
world.inspectfor an entity,world.inspect_componentandworld.inspect_component_typeworld.inspect_resourceandworld.inspect_all_resourcesworld.summarizefor entity, archetype and resource countsregistry.component_metadatafor the type map clients cacheStructured values are always on for remote replies. Unknown type names return a new error code. Serde derives for the world summary types are here too since they were waiting on the serde PR.
Not exposed: the cached variant of inspect, multi-entity inspection and fuzzy name lookup, which wait on #25010 and #25028.
AI disclosure
This is part of the inspector upstreaming series. When I started it, I worked out the goals and scope with Alice and used AI to split the working Jackdaw and feathers_inspector code into small reviewable pieces. For this one, AI did the mechanical port of the BRP verbs into
bevy_remoteand wrote the tests, and I reviewed the code and had it double check for problems. That turned up two things. CI never enables theclientfeature, so the new integration tests (and the client's own round trip tests from #25837) would have compiled empty, which is whybevy_remotenow lists itself as a dev-dependency withclienton. CodeQL also flagged test assertions that printed whole JSON replies as cleartext logging, so those messages are gone.