FontSource::Default - #25847
Merged
Merged
FontSource::Default #25847
FontSource::Default #25847Conversation
…efault` variant to `FontSource`. `DefaultFontSource` is looked up when resolving `FontSource::Default`. DefaultFontSource(FontSource::Default)` is mapped to the default font asset handle.
Zeophlite
added
A-UI
Zeophlite
approved these changes
Sep 19, 2026
Zeophlite
added
the
D-Modest
ickshonpe
added
A-Text
alice-i-cecile
added
the
M-Migration-Guide
alice-i-cecile
requested changes
Sep 21, 2026
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
IMO this doesn't warrant a release note: too minor. But I've added a suggestion to the migration guide to make it more clear.
Approach looks good though.
alice-i-cecile
added
X-Uncontroversial
…source_parameter.md Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
ickshonpe
added
S-Needs-Review
Contributor
Author
Yeah I don't know even why I added it, just running on auto pilot. |
alice-i-cecile
approved these changes
Sep 21, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #25842
Solution
FontSource::Defaultvariant.DefaultFontSourceresource, that newtypes aFontSource.FontSource::Defaultis used, it's replaced by theFontSourcefromDefaultFontSource.DefaultFontSource(FontSource::Default)is mapped toFontSource::Handle(Handle::default()).