Skip to content

Replace outdated #{...} usage in the bsn document - #25843

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
hxYuki:document
Sep 20, 2026
Merged

Replace outdated #{...} usage in the bsn document#25843
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
hxYuki:document

Conversation

@hxYuki

@hxYuki hxYuki commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Objective

  • #{...} syntax is no more valid now but still lives in Using Dynamic Expressions in Scenes section.

Solution

  • Replace with Name({name.to_string()}).

@alice-i-cecile alice-i-cecile added this to the 0.20 milestone Sep 19, 2026
@mnmaita mnmaita added C-Code-Quality A section of code that is hard to understand or change A-Scenes Composing and serializing ECS objects D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 19, 2026
mnmaita
mnmaita reviewed Sep 19, 2026
View reviewed changes
Comment thread crates/bevy_scene/src/lib.rs
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 20, 2026
@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Sep 20, 2026
Merged via the queue into bevyengine:main with commit d7bd8ef Sep 20, 2026
69 of 75 checks passed
@hxYuki
hxYuki deleted the document branch September 21, 2026 02:54
gregcsokas pushed a commit to gregcsokas/bevy that referenced this pull request Sep 21, 2026
@hxYuki @gregcsokas
Replace outdated #{...} usage in the bsn document (bevyengine#25843)
7f655c2 
# Objective

- `#{...}` syntax is no more valid now but still lives in `Using Dynamic
Expressions in Scenes` section.

## Solution

- Replace with `Name({name.to_string()})`.
mockersf pushed a commit that referenced this pull request Sep 25, 2026
@hxYuki @mockersf
Replace outdated #{...} usage in the bsn document (#25843)
0042a3e 
# Objective

- `#{...}` syntax is no more valid now but still lives in `Using Dynamic
Expressions in Scenes` section.

## Solution

- Replace with `Name({name.to_string()})`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes
+1 more reviewer
@mnmaita mnmaita mnmaita approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Scenes Composing and serializing ECS objects C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.20

Development

Successfully merging this pull request may close these issues.

3 participants

@hxYuki @alice-i-cecile @mnmaita