Skip to content

Make tree view expansion a marker component - #25835

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
jbuehler23:jackdaw/tree-expanded-marker
Sep 20, 2026
Merged

alice-i-cecile merged 1 commit into
bevyengine:mainfrom
jbuehler23:jackdaw/tree-expanded-marker

Conversation

@jbuehler23

Copy link
Copy Markdown
Contributor

Objective

Follow-up to #25821 addressing viridia's review. Expansion was a bool on the row, so nothing could feed it to the accessibility tree. As a marker component, like checked state, a hook can keep the accesskit expanded property in sync.

Part of #23013.

Solution

Added expandable and expanded markers to the ui crate's interaction states, next to the checked ones, with matching hooks that set or clear the accessibility property. The tree view reads the marker instead of a field and the self update observer inserts or removes it. Rows with children are marked expandable by the widget's post update pass, so leaf rows never report a collapsed state.

The expand request event keeps its bool payload since it is a request, not state.

AI disclosure

AI assistance was used to help port these changes and to plan this upstream series from our existing Jackdaw functionality. All changes were reviewed by a human before submission.

@jbuehler23
jbuehler23 force-pushed the jackdaw/tree-expanded-marker branch from 7b9597b to 5d10fa5 Compare September 18, 2026 07:41
@jbuehler23 jbuehler23 added C-Feature A new feature, making something new possible A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 18, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Sep 18, 2026
@alice-i-cecile alice-i-cecile added this to the 0.21 milestone Sep 18, 2026
@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 19, 2026
@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Sep 20, 2026
Merged via the queue into bevyengine:main with commit c868d3a Sep 20, 2026
48 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in UI Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants