Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
stuartparmenter
added
C-Bug
JMS55
added
S-Needs-Testing
Contributor
What glass surface? Solari does not support transparencies yet. I do not currently have time to test this, as I am quite busy prepping for the 0.20 release. Please find someone else to test side by side and confirm this improves denoising results, and post video/screenshot proof in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
When a reflection ray misses and hits the environment, the specular motion vector correctly points to infinity. However, the guide depth stays stuck at the glass surface, potentially causing inconsistencies for DLSS-RR.
Solution
Passed
psrandprimary_world_positionintopsr_environment_miss. Whenreplace_fullyis active, it overrides the virtual depth using the same scaling math as thereplace_primary_surfacehit branch.Albedo, normal, and other guide textures are untouched on a miss.
Testing
Cannot run with the
dlssfeature (no NVIDIA GPU). Tested on an RX 7900 XTX.Could someone test this on NVIDIA hardware by moving the camera parallel to a mirror that reflects the sky?
AI Disclosure: I used Claude to test it on my setup scene.